Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] include path is ambiguous #8

Open
toge opened this issue Sep 5, 2024 · 1 comment
Open

[BUG] include path is ambiguous #8

toge opened this issue Sep 5, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@toge
Copy link
Contributor

toge commented Sep 5, 2024

Describe the bug

In examples, the include path is fixedmath.
https://github.com/arturbac/fixed_math/blob/v2.0.0/examples/brief-usage.cc#L5-L6

But the include path is fixed_math.
https://github.com/arturbac/fixed_math/blob/master/fixed_lib/CMakeLists.txt#L25-L30

Which is valid?

I think fixedmath is valid because common.h includes <fixedmath/detail/type_traits.h>.
https://github.com/arturbac/fixed_math/blob/v2.0.0/fixed_lib/include/fixedmath/detail/common.h#L8

Build info:

  • OS: Fedora Linux 40
  • gcc 14.2.1
  • libstdc++ 14.2.1
@toge toge added the bug Something isn't working label Sep 5, 2024
@arturbac
Copy link
Owner

arturbac commented Sep 7, 2024

Yes, looks like You are right.
I use it by CPM dependency so I do not need to install and did not now about this.
Will asap fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

2 participants