-
-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New R-hat, ESS and quantile-MCSE functions + related plots + rank plots #621
Comments
@avehtari thanks to you and collaborators for the nice paper, releasing code at the same time, and for reaching out to help get this all implemented! Two questions on rank plots:
|
Yes, but that they are not sufficient as mentioned in SBC paper. I think the benefit of rank plots is the simple interpretation. Additional figure type would be ECDF difference as in Fig 14c in SBC paper. It has a better envelope, but it requires more explanation and thus both are useful to have.
Yes, we recommend Rhat, bulk-ESS, tail-ESS and HMC specific diagnostics for automatic diagnostics and rank plots for helping to see where the problem is or if you want to check just some rank plots.
I don't like it for this purpose as it's not that familiar for people as histograms and would require additional explanation without containing additional information. I would instead consider adding ECDF difference plot, which has the benefit of being more sensitive to changes in the edges and takes into account dependencies like clustering unlike histogram error bar. |
Add new R-hat, ESS, quantile-MCSE and new plots described in
The reference code in R is available in monitornew.R and in monitorplot.R. I think porting required computation from monitornew.R is easy and porting the plots may require a bit more work, but I'm not expert on Python graphics.
There might be also something useful in the corresponding issues for rstan stan-dev/rstan#617 and bayesplot stan-dev/bayesplot#178
The text was updated successfully, but these errors were encountered: