Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Arctic and East Pacific GFS Wave Layer Boundaries #172

Open
jamesdoyle21 opened this issue Nov 10, 2021 · 9 comments
Open

Fix Arctic and East Pacific GFS Wave Layer Boundaries #172

jamesdoyle21 opened this issue Nov 10, 2021 · 9 comments
Assignees
Labels
bug Something isn't working EDS Issues OTT Only Only charge to OTT

Comments

@jamesdoyle21
Copy link
Collaborator

jamesdoyle21 commented Nov 10, 2021

The boundaries cover the global scale but the layer ends at about the US/ Canada border. We found this when testing the new real time map view feature. This includes the Arctic Wave Height, Wave Period, and Wave Direction layers.

image

@jamesdoyle21 jamesdoyle21 added the bug Something isn't working label Nov 10, 2021
@nguyandy
Copy link
Collaborator

http://tds.eds.ioos.us/ncWMS2/wms?SERVICE=WMS&REQUEST=GetCapabilities&VERSION=1.3.0

Source data will have to be updated.
Getcap is also returning global extents.

<westBoundLongitude>-180.0</westBoundLongitude>
<eastBoundLongitude>180.0</eastBoundLongitude>
<southBoundLatitude>-90.0</southBoundLatitude>
<northBoundLatitude>90.0</northBoundLatitude>

@jamesdoyle21 jamesdoyle21 changed the title Fix Arctic GFS Wave Layer Boundaries Fix Arctic and East Pacific GFS Wave Layer Boundaries Nov 10, 2021
@jamesdoyle21
Copy link
Collaborator Author

Also noticed issues with the East Pacific GFS Wave boundaries

image

@jamesdoyle21 jamesdoyle21 added the Maracoos & OTT Split time between these jobs label Nov 10, 2021
@mpiannucci mpiannucci self-assigned this Nov 15, 2021
@mpiannucci mpiannucci removed their assignment Nov 30, 2021
@jamesdoyle21
Copy link
Collaborator Author

Hey @patrick-tripp can you take a look at this issue and give us your thoughts? Maybe Ben, or someone from the backend can tackle this. We have several features in OM3 that use this bounding box, so it is important we have those correct. Thanks

@patrick-tripp
Copy link
Member

I updated the THREDDS metadata for all of the gfswave collections. Hopefully they will provide the correct extents after tonight's restart. Let me know if it works or not. Thanks.

@jamesdoyle21
Copy link
Collaborator Author

Hey I am still seeing the big bounding box here

image

@nguyandy
Copy link
Collaborator

nguyandy commented Dec 9, 2021

@jamesdoyle21 I'm rebuilding the catalog atm, the updated bbox will show after that's done.

@nguyandy
Copy link
Collaborator

nguyandy commented Dec 13, 2021

The rebuilt catalog is up on dev, but the bbox is still big.

https://eds.ioos.us/wms/?SERVICE=WMS&REQUEST=GetCapabilities&VERSION=1.1.1&DATASET=GFS_WAVE_ARCTIC
Checking getCap, the boundary doesn't look like it's been updated.

<LatLonBoundingBox minx="-180.0" maxx="180.0" miny="-90.0" maxy="90.0"/>
<BoundingBox SRS="CRS:84" minx="-180.0" maxx="180.0" miny="-90.0" maxy="90.0"/>

and ncWMS last updated time for Arctic is Last update date: 2021-12-13

@patrick-tripp

@mpiannucci mpiannucci added OTT Only Only charge to OTT and removed Maracoos & OTT Split time between these jobs labels Dec 28, 2021
@jamesdoyle21
Copy link
Collaborator Author

@patrick-tripp did you have someone in mind who could take a look at this?

@mpiannucci
Copy link
Contributor

mpiannucci commented Jun 21, 2022

The East pacific one is correct actually, you can see how it wraps. This is fine for me, theres not really a better way to handle this cuz it wraps the date line

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working EDS Issues OTT Only Only charge to OTT
Projects
None yet
Development

No branches or pull requests

6 participants