Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate CO-OPS Stations with Just Tide Predictions vs Ones with Water Level Measurements #434

Open
jamesdoyle21 opened this issue Apr 13, 2022 · 18 comments
Assignees
Labels
OTT Only Only charge to OTT

Comments

@jamesdoyle21
Copy link
Collaborator

jamesdoyle21 commented Apr 13, 2022

OceansMap Bug Tracker line 40

This is an issue that has layers and is causing problems down the line. The problem is that CO-OPS stations labeled "Water Levels" contain 2 types of station: stations with both measured water level data and tidal predictions and stations with only tidal predictions. We need to differentiate these because the stations with tidal predictions only have no real-time data - just predictions.

Matt, Chris and I did not have a clear solution to this. Ideally, we would add a 5th category to the CO-OPS stations titled "Tide Predictions" which contains all the stations with only tide predictions and nothing else. This is a challenging problem though apparently, so it may require some discussion of how to do this here.

This issue directly relates to #435. If we can create a separate group for the tide prediction only stations, we can remove these from the validation tool completely to solve #435.

image

@kvmartin001
Copy link
Collaborator

For #429 I'm adding the category as an actual data attribute, so the category will be readable by the validation tool.

@jamesdoyle21
Copy link
Collaborator Author

jamesdoyle21 commented Apr 18, 2022

The red Water Levels stations are coming up orange on my map. This might be because all the statuions are out of date, but either way, this should be easier to read.

Also, I am not seeing this change in the Client Demo instance

Putting this back into In Progress @kvmartin001

image

@jamesdoyle21
Copy link
Collaborator Author

The other thing is there are many stations with Water Level listed as a parameter, but never have data for this.

@cpaternostro can you confirm, should data stations like the one listed below be labeled as a Water Level Station or a Tide Prediction station?

image

@kvmartin001
Copy link
Collaborator

@jamesdoyle21 Yeah the color problem is because of the out-of-date fade. Didn't notice on Fri because most stations were current. How's this?
image

@jamesdoyle21
Copy link
Collaborator Author

Much better

@cpaternostro
Copy link

cpaternostro commented Apr 20, 2022 via email

@jamesdoyle21
Copy link
Collaborator Author

@kvmartin001 see Chris's comment here. Many of the stations we have labeled red (Active WL) have not had water level data here in 30+ years. Correct me if I am wrong here Kevin, but I believe any station that has ever had water level data at one point is labeled red in OceansMap right now. So, @cpaternostro, we would need a list of the co-ops stations that are just tide prediction stations so Kevin can go in and set each one. Let me know if there is an easier way around this.

@jamesdoyle21
Copy link
Collaborator Author

This is also a backend issue because parameters that haven't had data in 37 years probably shouldn't be showing up in OceansMap..

@kvmartin001
Copy link
Collaborator

@jamesdoyle21 yes, you're right about the labels. I'm labeling stations by the Parameters list, which is in the OceansMap Catalog Item. The parameters come directly from the data service, https://opendap.co-ops.nos.noaa.gov/ioos-dif-sos/ in this case. Maybe our backend needs a filter that removes parameters from the list if they aren't considered current.

As you said, I could also add logic on the frontend that would paint stations based on their ID.

@mpiannucci
Copy link
Contributor

I would really rather not do that @kvmartin001 It should be all driven from the data availabel in the catalog

@cpaternostro
Copy link

cpaternostro commented Apr 20, 2022 via email

@jamesdoyle21
Copy link
Collaborator Author

I am going to leave this issue open. Let's plan to discuss with @cpaternostro on Tuesday

@mpiannucci
Copy link
Contributor

Data catalog should be updated to use get caps to query station availabaility

https://opendap.co-ops.nos.noaa.gov/ioos-dif-sos/SOS?service=SOS&request=GetCapabilities&version=1.0.0

@jamesdoyle21
Copy link
Collaborator Author

@cpaternostro we now have Tide Prediction stations separated from Water Level stations. Can you take a look at this and let us know your thoughts? Most of the stations labeled Water Level only have tide prediction data because the water level data gives a warning and is grayed out. Curious on your thoughts how to best handle these labels

@kvmartin001
Copy link
Collaborator

We still need to edit Data Catalog to add support for Water Leve active / inactive status.

@mpiannucci On second look here, I'm not seeing any stations tagged as active / inactive in the GetCaps (link above).

There's a DescribeSensor request that looks promising. You can specify a SOS procedure, in this case urn:ioos:network:NOAA.NOS.CO-OPS:WaterLevelActive, and it gives you the list of active water level stations:
https://opendap.co-ops.nos.noaa.gov/ioos-dif-sos/SOS?service=SOS&request=DescribeSensor&version=1.0.0&outputFormat=text%2Fxml%3Bsubtype%3D%22sensorML%2F1.0.1%2Fprofiles%2Fioos_sos%2F1.0%22&procedure=urn:ioos:network:NOAA.NOS.CO-OPS:WaterLevelActive

About the DescribeSensor request
https://opendap.co-ops.nos.noaa.gov/ioos-dif-sos/ClientGetter?p=3

@mpiannucci
Copy link
Contributor

mpiannucci commented May 12, 2022

Are we using opendap or scidap currently for coops data? We should have a very real discussion about whether we keep using scidap for this or hit their opendap directly. For coops OTT, I am partial to hitting them directly. The other versions can use scidap. @kvmartin001 can you do a look through how we do the harvesting and datacatalot stuff currently and see if this could be added to how we do things now?

@kvmartin001
Copy link
Collaborator

kvmartin001 commented May 12, 2022

@mpiannucci Yeah I'll take a look. We're currently using SciDAP for CO-OPS simply because our function always tries SciDAP first.
Where should the info be stored in the catalog? Maybe we add a "WaterLevelActive" string to the tags list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OTT Only Only charge to OTT
Projects
None yet
Development

No branches or pull requests

4 participants