Nested table not rendered properly

[ivanhjc]

In my browser (Chrome Version 77.0.3865.90) the live preview of the table

[cols="1,3,5"]
|===
| Foo | Foo | Foo

| Foo
a| Foo

[cols="1,2"]
!===
! Foo ! Foo
! Foo ! Foo
! Foo ! Foo
!===

| Foo 

| Foo | Foo | Foo
|===

looks like this

But it displays normally when processed to html using asciidoctor:

[mojavelinux]

@Mogztter I think this is related to a fix that was made for the upcoming 2.0.11. See asciidoctor/asciidoctor#3370

[ggrossetie]

@mojavelinux Maybe... which versions are affected? If I'm not mistaken, we are using the Asciidoctor stylesheet from version 2.0.9.

@ivanhjc Could you please share with us the output of asciidoctor -v?

[ivanhjc]

@Mogztter

$ asciidoctor -v
Asciidoctor 1.5.6.1 [http://asciidoctor.org]
Runtime Environment (ruby 2.6.3p62 (2019-04-16 revision 67580) [x86_64-linux]) (lc:UTF-8 fs:UTF-8 in:- ex:UTF-8)

Also Asciidoctor.js version is 2.3.0.

[mojavelinux]

@Mogztter The fix is not yet in a release, so you'd need to grab it from master. I'm pretty sure it's the same issue.

[ggrossetie]

Yes, good catch!
It's confirmed by @ivanhjc.

I guess I could perform a new release of Asciidoctor.js based on the lastest commit on master.

[mojavelinux]

I'd rather you not do that because that would go outside the process we agreed on. I absolutely agree an Asciidoctor core release needs to go out. It's just that, of all weeks, this is absolutely terrible week for me. So it needs to wait until the break (which is the following two weeks). Then, we can get back on schedule.

[ggrossetie]

I'd rather you not do that because that would go outside the process we agreed on.

No worries, I thought you were suggesting to do a release from master but I must have misunderstood your reply:

The fix is not yet in a release, so you'd need to grab it from master.

I guess it was a workaround solution (ie. grab the stylesheet from master and add it as a custom stylesheet in the options page)

I absolutely agree an Asciidoctor core release needs to go out. It's just that, of all weeks, this is absolutely terrible week for me. So it needs to wait until the break (which is the following two weeks). Then, we can get back on schedule.

As always, if I can be of any help, ping me 😉

[mojavelinux]

I thought you were suggesting to do a release from master

Sorry for the confusion. I was suggesting that the browser extension could use the stylesheet from master temporarily if you wanted to patch it ahead of time. Though it probably is best if we wait for the release to come around as this issue isn't really a blocker.

[ggrossetie]

Sorry for the confusion. I was suggesting that the browser extension could use the stylesheet from master temporarily if you wanted to patch it ahead of time.

Gotcha.
Yes, I don't want to do that, especially since the build copy the stylesheet from the npm package:

asciidoctor-browser-extension/tasks/builder.js

Line 94 in e7fc22c

bfs.copySync('node_modules/@asciidoctor/core/dist/css/asciidoctor.css', 'app/css/themes/asciidoctor.css')

Though it probably is best if we wait for the release to come around as this issue isn't really a blocker.

We will wait for the release 👍

[mojavelinux]

The most important part was that we confirmed that the upstream fix covered this case ;)