You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After asciidoctor-kroki upgrade from version 0.17 to 0.18.1, I have experiencing Cannot find module ./node-fs.js error in browser context (asciidoctor-kroki running in browser).
The error occurs on const parse = typeof vfs !== 'undefined' && typeof vfs.parse === 'function' ? vfs.parse : require('./node-fs.js').parse
becase typeof vfs.parse is "object".
Than, I've changed line back to 0.17.0 version text = preprocessPlantUmlIncludes(text, path.dirname(result.filePath), includeOnce, includeStack, includePaths, vfs, logger)
and browser context works fine now.
I am not JS developer, I unsure I'll able to make correct patch. Hope someone fix this.
Tested in Yandex.Browser (Chromium engine) version 24.12.0.1845 on Mac OS 14.7.1
The text was updated successfully, but these errors were encountered:
After asciidoctor-kroki upgrade from version 0.17 to 0.18.1, I have experiencing
Cannot find module ./node-fs.js
error in browser context (asciidoctor-kroki running in browser).I am not JS developer, but made some debugging in browser dev tools and found source of error.
Here is a breaking change between versions(see line 152 of preprocess.js):
v0.17.0...v0.18.1#diff-cce3483983413018bc60906dc038fe0c28ab443f7910d69110d055a81fa70f18R152
The error occurs on
const parse = typeof vfs !== 'undefined' && typeof vfs.parse === 'function' ? vfs.parse : require('./node-fs.js').parse
becase
typeof vfs.parse
is "object".Than, I've changed line back to 0.17.0 version
text = preprocessPlantUmlIncludes(text, path.dirname(result.filePath), includeOnce, includeStack, includePaths, vfs, logger)
and browser context works fine now.
I am not JS developer, I unsure I'll able to make correct patch. Hope someone fix this.
Tested in Yandex.Browser (Chromium engine) version 24.12.0.1845 on Mac OS 14.7.1
The text was updated successfully, but these errors were encountered: