potential out-of-order operations on table name change

[albinkc]

Migration file: https://github.com/albinkc/helpdesk/blob/main/priv/repo/migrations/20240430205016_rename_representative.exs

changing table name, keeping everything else intact, gives me this error:

albin@Albins-MacBook-Pro helpdesk % mix ash.migrate                      
Getting extensions in current project...
Running migration for AshPostgres.DataLayer...

02:20:46.825 [info] == Running 20240430205016 Helpdesk.Repo.Migrations.RenameRepresentative.up/0 forward

02:20:46.827 [info] drop constraint tickets_representative_id_fkey from table tickets

02:20:46.829 [info] create table representatives

02:20:46.836 [info] alter table tickets
** (Postgrex.Error) ERROR 23503 (foreign_key_violation) insert or update on table "tickets" violates foreign key constraint "tickets_representative_id_fkey"

    table: tickets
    constraint: tickets_representative_id_fkey

Key (representative_id)=(d75edc31-72d0-4e95-b840-2f5cd934aeb5) is not present in table "representatives".
    (ecto_sql 3.11.1) lib/ecto/adapters/sql.ex:1054: Ecto.Adapters.SQL.raise_sql_call_error/1
    (elixir 1.16.2) lib/enum.ex:1700: Enum."-map/2-lists^map/1-1-"/2
    (ecto_sql 3.11.1) lib/ecto/adapters/sql.ex:1161: Ecto.Adapters.SQL.execute_ddl/4
    (ecto_sql 3.11.1) lib/ecto/migration/runner.ex:348: Ecto.Migration.Runner.log_and_execute_ddl/3
    (elixir 1.16.2) lib/enum.ex:1700: Enum."-map/2-lists^map/1-1-"/2
    (elixir 1.16.2) lib/enum.ex:1700: Enum."-map/2-lists^map/1-1-"/2
    (ecto_sql 3.11.1) lib/ecto/migration/runner.ex:311: Ecto.Migration.Runner.perform_operation/3
    (stdlib 5.2) timer.erl:270: :timer.tc/2

[zachdaniel]

Ahhhhhhhhhhh, right. I think this is because the migration generator doesn't currently handle table renaming. It just makes the new table and leaves the old one there. This is naturally not ideal :)

To fix this, we'd need to handle table renames, as part of #224, where if a table is missing, we check to see if you're trying to rename it to some new table being added. Going to close this in favor of a note in that issue.