From 664f692e023f555a37eed6baafe171937bab5d60 Mon Sep 17 00:00:00 2001 From: Ashish Banerjee Date: Fri, 15 Nov 2024 15:20:37 -0500 Subject: [PATCH] Fix failing unit tests --- .../remove-hardcoded-namespace-in-tracing-test-v1.17.x.yaml | 3 ++- test/kube2e/upgrade/upgrade_utils_test.go | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/changelog/v1.17.17/remove-hardcoded-namespace-in-tracing-test-v1.17.x.yaml b/changelog/v1.17.17/remove-hardcoded-namespace-in-tracing-test-v1.17.x.yaml index 23a513d6240..3692f1b47e7 100644 --- a/changelog/v1.17.17/remove-hardcoded-namespace-in-tracing-test-v1.17.x.yaml +++ b/changelog/v1.17.17/remove-hardcoded-namespace-in-tracing-test-v1.17.x.yaml @@ -1,7 +1,8 @@ changelog: - type: NON_USER_FACING description: >- - Fix failing unit test in `test/kubernetes/testutils/helper/util_test.go` + Fix failing unit tests in `test/kubernetes/testutils/helper/util_test.go` + and `test/kubernetes/testutils/helper/util_test.go` - type: NON_USER_FACING issueLink: https://github.com/solo-io/solo-projects/issues/7223 resolvesIssue: false diff --git a/test/kube2e/upgrade/upgrade_utils_test.go b/test/kube2e/upgrade/upgrade_utils_test.go index b12948c79bb..6be4156498a 100644 --- a/test/kube2e/upgrade/upgrade_utils_test.go +++ b/test/kube2e/upgrade/upgrade_utils_test.go @@ -26,9 +26,9 @@ var _ = Describe("upgrade utils unit tests", func() { It("should return latest patch", func() { ctx := context.Background() client, _ := githubutils.GetClient(ctx) - minor, err := getLatestReleasedPatchVersion(ctx, client, "gloo", 1, 8) + minor, err := getLatestReleasedPatchVersion(ctx, client, "gloo", 1, 9) Expect(err).NotTo(HaveOccurred()) - Expect(minor.String()).To(Equal("v1.8.37")) + Expect(minor.String()).To(Equal("v1.9.30")) }) })