Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: aspect lint fails when using fail_on_validation in 1.0.0-rc3 #269

Open
ewhauser opened this issue May 31, 2024 · 1 comment
Open
Assignees
Labels
bug Something isn't working

Comments

@ewhauser
Copy link
Contributor

ewhauser commented May 31, 2024

What happened?

Linters fail when using fail_on_validation:

Traceback (most recent call last):
        File "/private/var/tmp/_bazel_ewhauser/7f94d8e82ee14a19aaeabeb129bad8ac/external/aspect_rules_lint~override/lint/ruff.bzl", line 122, column 17, in _ruff_aspect_impl
                ruff_fix(ctx, ctx.executable, files_to_lint, ctx.files._config_files, patch, report, exit_code)
        File "/private/var/tmp/_bazel_ewhauser/7f94d8e82ee14a19aaeabeb129bad8ac/external/aspect_rules_lint~override/lint/ruff.bzl", line 105, column 58, in ruff_fix
                "JS_BINARY__EXIT_CODE_OUTPUT_FILE": exit_code.path,
Error: 'NoneType' value has no field or method 'path'
Use --verbose_failures to see the command lines of failed build steps.

Version

1.0.0-rc3

How to reproduce

Create a .bazeliskrc in ./examples:

BAZELISK_BASE_URL=https://github.com/aspect-build/aspect-cli/releases/download
USE_BAZEL_VERSION=aspect/5.9.35

Add the following to .bazelrc:

common --@aspect_rules_lint//lint:fail_on_violation

Run:

bazel lint //...

Any other information?

No response

@ewhauser ewhauser added the bug Something isn't working label May 31, 2024
@alexeagle alexeagle self-assigned this May 31, 2024
@ewhauser
Copy link
Contributor Author

@alexeagle Not sure if it is just me but I still see this issue when using the setting:

 common --@aspect_rules_lint//lint:fail_on_violation

in the 1.0+ versions. Having trouble figuring out a configuration to disable the fix config so I'm patching it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants