From 8f365542bf0c07c15eb6659a4caaae987e8031d7 Mon Sep 17 00:00:00 2001 From: Greg Magolan Date: Wed, 8 May 2024 11:58:39 -0700 Subject: [PATCH] chore: bump to buildifier 6.4.0 (#97) --- .pre-commit-config.yaml | 6 +++--- BUILD.bazel | 13 ++++++++++--- MODULE.bazel | 4 +++- internal_deps.bzl | 8 +++----- 4 files changed, 19 insertions(+), 12 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index ec8f659..af1c35f 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -9,18 +9,18 @@ default_stages: [commit] repos: # Check formatting and lint for starlark code - repo: https://github.com/keith/pre-commit-buildifier - rev: 4.0.1.1 + rev: 6.4.0 hooks: - id: buildifier - id: buildifier-lint # Enforce that commit messages allow for later changelog generation - repo: https://github.com/commitizen-tools/commitizen - rev: v2.18.0 + rev: v3.24.0 hooks: # Requires that commitizen is already installed - id: commitizen stages: [commit-msg] - repo: https://github.com/pre-commit/mirrors-prettier - rev: 'v2.4.0' + rev: v3.1.0 hooks: - id: prettier diff --git a/BUILD.bazel b/BUILD.bazel index 260e22f..af2de68 100644 --- a/BUILD.bazel +++ b/BUILD.bazel @@ -4,13 +4,20 @@ load("@npm//:defs.bzl", "npm_link_all_packages") npm_link_all_packages(name = "node_modules") +buildifier( + name = "buildifier", + exclude_patterns = ["./.git/*"], + lint_mode = "fix", + mode = "fix", + tags = ["manual"], # tag as manual so windows ci does not build it by default +) + buildifier( name = "buildifier.check", - exclude_patterns = [ - "./.git/*", - ], + exclude_patterns = ["./.git/*"], lint_mode = "warn", mode = "diff", + tags = ["manual"], # tag as manual so windows ci does not build it by default ) bzl_library( diff --git a/MODULE.bazel b/MODULE.bazel index 5ce5228..de438eb 100644 --- a/MODULE.bazel +++ b/MODULE.bazel @@ -24,7 +24,9 @@ rollup.toolchain( ) use_repo(rollup, "rollup") -bazel_dep(name = "buildifier_prebuilt", version = "6.1.2", dev_dependency = True) +####### Dev dependencies ######## + +bazel_dep(name = "buildifier_prebuilt", version = "6.4.0", dev_dependency = True) npm = use_extension( "@aspect_rules_js//npm:extensions.bzl", diff --git a/internal_deps.bzl b/internal_deps.bzl index 08632b7..5809cc4 100644 --- a/internal_deps.bzl +++ b/internal_deps.bzl @@ -17,9 +17,7 @@ def rules_rollup_internal_deps(): http_archive( name = "buildifier_prebuilt", - sha256 = "72b5bb0853aac597cce6482ee6c62513318e7f2c0050bc7c319d75d03d8a3875", - strip_prefix = "buildifier-prebuilt-6.3.3", - urls = [ - "http://github.com/keith/buildifier-prebuilt/archive/6.3.3.tar.gz", - ], + sha256 = "8ada9d88e51ebf5a1fdff37d75ed41d51f5e677cdbeafb0a22dda54747d6e07e", + strip_prefix = "buildifier-prebuilt-6.4.0", + urls = ["http://github.com/keith/buildifier-prebuilt/archive/6.4.0.tar.gz"], )