Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add provides-extra to the lockfile #10953

Open
charliermarsh opened this issue Jan 25, 2025 · 1 comment · May be fixed by #11063
Open

Add provides-extra to the lockfile #10953

charliermarsh opened this issue Jan 25, 2025 · 1 comment · May be fixed by #11063
Assignees
@Gankra
Labels
enhancement New feature or improvement to existing functionality

Comments

@charliermarsh
Copy link
Member

charliermarsh commented Jan 25, 2025 •
edited
Loading

Summary

We write requires-dist, but not provides-extra, so it's not possible to determine the set of valid extras (since an extra could be empty, in which case, it wouldn't appear in requires-dist).
@charliermarsh charliermarsh added the enhancement New feature or improvement to existing functionality label Jan 25, 2025
@charliermarsh
Copy link
Member Author

Basically, we want to add provides-extra here:

uv/crates/uv-resolver/src/lock/mod.rs

Line 2632 in 1ef47aa

requires_dist: BTreeSet<Requirement>,

And then serialize and deserialize it like we do for requires-dist.

@Gankra Gankra self-assigned this Jan 25, 2025
@Gankra Gankra linked a pull request Jan 29, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gankra Gankra

Labels
enhancement New feature or improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add provides-extras to lockfile astral-sh/uv
2 participants
@Gankra @charliermarsh