Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: thick disc transfer functions #202

Closed
fjebaker opened this issue Jun 27, 2024 · 0 comments · Fixed by #203
Closed

Regression: thick disc transfer functions #202

fjebaker opened this issue Jun 27, 2024 · 0 comments · Fixed by #203
Labels
bug Something isn't working

Comments

@fjebaker
Copy link
Member

Probably introduced in changing the solver in #190, thick disc transfer functions for small Eddington ratio, low spin, and close to the ISCO are awful. Since the performance improvement of the non-linear solvers is small for thick discs (#198), maybe we select the old Roots.jl algorithm for these problems.
@fjebaker fjebaker added the bug Something isn't working label Jun 27, 2024
@fjebaker fjebaker mentioned this issue Jun 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Attempt to fix thick disc transfer functions astro-group-bristol/Gradus.jl
1 participant
@fjebaker