Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] index set returned by some bootstraps is list of numpy arrays, not single numpy array #81

Open
fkiraly opened this issue Feb 23, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@fkiraly
Copy link
Collaborator

fkiraly commented Feb 23, 2024

See #26 (comment)

This issue is a tracking issue for a remaining bug that has been patched over by a bandaid.

Some bootstrappers, namely those inheriting from BlockBootstrap, return lists of np.ndarray as index set, as opposed to a single np.ndarray. The returned list of arrays corresponds to the individual blocks whic hare later concatenated.

This is for now patched over in BaseTimeSeriesBootstrap, but that is only a bandaid as it broadens the extension contract, these lines:

            # hack to fix known issue with non-concatenated index sets
            # see bug issue #81
            if isinstance(indices, list):
                indices = np.concatenate(indices, axis=0)

The fix should remove these lines and not lead to failures in the skbase testing framework.

@fkiraly fkiraly added the bug Something isn't working label Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant