Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] proxyHost and proxyPort for some commands can be passed through arguments even tough not being read and used through arguments. #1667

Closed
2 tasks done
neoandmatrix opened this issue Feb 15, 2025 · 3 comments · Fixed by #1669
Labels
bug Something isn't working

Comments

@neoandmatrix
Copy link
Contributor

Describe the bug.

While working on the issue #1621 found that the proxyHost and proxyPort can be passed from arguments but are not read or used. More explanation in the comment. The issue is mainly related to 3 commands [asyncapi validate [SPEC-FILE] [PROXYHOST] [PROXYPORT]] , [asyncapi optimize [SPEC-FILE] [PROXYHOST] [PROXYPORT]] , [asyncapi convert [SPEC-FILE] [PROXYHOST] [PROXYPORT]].

Expected behavior

proxyPort and proxyHost should only be passed via flags.

Screenshots

From docs.

Image

How to Reproduce

Run help for any of the above mentioned 3 commands and they display that proxyHost and proxyPort can be passed via arguments.

🥦 Browser

None

👀 Have you checked for similar open issues?

  • I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

Yes I am willing to submit a PR!

@neoandmatrix neoandmatrix added the bug Something isn't working label Feb 15, 2025
@github-project-automation github-project-automation bot moved this to To Triage in CLI - Kanban Feb 15, 2025
@neoandmatrix
Copy link
Contributor Author

@AayushSaini101 can you please review this and if valid i would like to work upon it.

Thanks.

@neoandmatrix neoandmatrix changed the title [BUG] proxyHost and proxyPort for some commands can be passed through arguments even tough not being read and used through arguments. [BUG] proxyHost and proxyPort for some commands can be passed through arguments even tough not being read and used through arguments. Feb 15, 2025
@AayushSaini101
Copy link
Collaborator

@AayushSaini101 can you please review this and if valid i would like to work upon it.

Thanks.
yes, please

@neoandmatrix
Copy link
Contributor Author

@AayushSaini101 can you please review this and if valid i would like to work upon it.

Thanks.
yes, please

Sure on it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants