Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update code to support @octokit/request v9 and @octokit/graphql v8 #3690

Open
coderabbitai bot opened this issue Feb 16, 2025 · 2 comments · May be fixed by #3697
Open

fix: Update code to support @octokit/request v9 and @octokit/graphql v8 #3690

coderabbitai bot opened this issue Feb 16, 2025 · 2 comments · May be fixed by #3697
Labels
area/javascript area/typescript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. good first issue Good for newcomers

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 16, 2025

The tests are failing after upgrading @octokit/request to v9.2.2 and @octokit/graphql to v8.2.1.

This issue tracks the required code changes to support these newer versions.

Context:

The fix might require changes to the actual code rather than tests to accommodate breaking changes in the new versions.

@anshgoyalevil anshgoyalevil removed their assignment Feb 16, 2025
@anshgoyalevil anshgoyalevil added good first issue Good for newcomers area/typescript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. area/javascript labels Feb 16, 2025
@SujitShres1ha
Copy link

Can I work on this?

@akshatnema
Copy link
Member

@SujitShres1ha Yeah, you can work on this.

Recxsmacx added a commit to Recxsmacx/website that referenced this issue Feb 18, 2025
Fixes asyncapi#3690

Update code to support `@octokit/request` v9.2.2 and `@octokit/graphql` v8.2.1.

* **netlify/functions/github_discussions.ts**
  - Remove unused import of `GraphQlQueryResponseData`.
  - Update `graphql` function call to use the new syntax.
  - Update authorization header to use the new token format.

* **netlify/functions/save-discussion-background/helpers.ts**
  - Update authorization header to use the new token format.
Recxsmacx added a commit to Recxsmacx/website that referenced this issue Feb 18, 2025
Fixes asyncapi#3690

Update code to support `@octokit/request` v9.2.2 and `@octokit/graphql` v8.2.1.

* **netlify/functions/github_discussions.ts**
  - Remove unused import of `GraphQlQueryResponseData`.
  - Update `graphql` function call to use the new syntax.
  - Update authorization header to use the new token format.

* **netlify/functions/save-discussion-background/helpers.ts**
  - Update authorization header to use the new token format.
Recxsmacx added a commit to Recxsmacx/website that referenced this issue Feb 18, 2025
Fixes asyncapi#3690

Update code to support `@octokit/request` v9.2.2 and `@octokit/graphql` v8.2.1.

* Update `netlify/functions/github_discussions.ts` to use the new `@octokit/graphql` v8.2.1 syntax and update the authorization header to use the new token format.
* Update `netlify/functions/save-discussion-background/helpers.ts` to use the new `@octokit/graphql` v8.2.1 syntax and update the authorization header to use the new token format.
* Update `package.json` to include `@octokit/request` v9.2.2 and `@octokit/graphql` v8.2.1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment