Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify save_settings #23

Open
probonopd opened this issue Apr 16, 2021 · 7 comments
Open

Clarify save_settings #23

probonopd opened this issue Apr 16, 2021 · 7 comments

Comments

@probonopd
Copy link
Contributor

probonopd commented Apr 16, 2021

If one uses "Set base freq offset" and clicks on "save_settings", is this setting then automatically applied after a reboot of the ESP32 or does one need to click "get settings" in order to load it? I am asking because after a reboot the web page does not seem to have "remembered" the settings.

Also, does one have to cleick "Do sync" after a reboot or does it do the sync (using the settings) automatically?

@atc1441
Copy link
Owner

atc1441 commented Apr 16, 2021

The offset is saved with save_settings and will be used on reboot.

The get settings button will get the current settings, it is still missing to parse that answer and set it in the input fields to "remember" it.
So on load of the .htm a one time request needs to be implemented that will request the current settings.

A sync is done every 500 periods, so on reboot it needs to be fired manualy to get a quick sync

@kgarrels
Copy link

could we foresee an option to do a sync after reboot?

@atc1441
Copy link
Owner

atc1441 commented Apr 16, 2021

It was there but i removed it for development. Its simple to add again :)

@kgarrels
Copy link

kgarrels commented Apr 16, 2021 via email

@atc1441
Copy link
Owner

atc1441 commented Apr 16, 2021

You can set this value

To 490 and it will resync on reboot :)

@probonopd
Copy link
Contributor Author

Is there a reason why we don't do this by default?

@atc1441
Copy link
Owner

atc1441 commented Apr 16, 2021

Because if an activation is wanted to perform directly after reboot it can get problematic.

The displays already received an wakeup cmd then and will not listen to the activation cmd anymore.

Thats what i meant i removed it for development, it is "activated" again and the esp32 is running for a while it makes no difference anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants