Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to use Mastercrud inside tabs as it is with CRUD? #25

Closed
rapgithub opened this issue Nov 22, 2018 · 5 comments
Closed

Ability to use Mastercrud inside tabs as it is with CRUD? #25

rapgithub opened this issue Nov 22, 2018 · 5 comments

Comments

@rapgithub
Copy link

Is it possible to use mastercrud inside tabs as it is with CRUD only?

I tried to do this but only works for one single model in this case Events model...

  $tabs->addTab('Events', function($p) use($app) {

    $m = $p->add(new MasterCRUD());
    $m->setModel(new Events($app->db), ['Images'=>[]]);

  });

if I click the relational model Images the layout is destroyed and the url address change to this:

html ?atk_narrow_tabs_tabssubview_virtualpage=cut&all_events_id=52

Instead the code below works inside tabs without issues, but only for one model definition...

  $tabs->addTab('Events', function($p) use($app) {
    $m = $p->add('CRUD')->setModel(new Events($app->db));
  });

Any ideas how to make use of mastercrud inside tabs?
thanks for the ideas!

@romaninsh
Copy link
Member

romaninsh commented Nov 22, 2018

i don't think that's possible. Wizard and MasterCRUD cannot be contained inside a JS element because they rely on links.

@PhilippGrashoff
Copy link

related to atk4/ui#451

@DarkSide666 DarkSide666 changed the title Ability to use Mastercrud inside tabs as it is with Grud? Ability to use Mastercrud inside tabs as it is with CRUD? Dec 1, 2018
@PhilippGrashoff
Copy link

So should we close this or keep it as a feature request?

@DarkSide666
Copy link
Member

Not sure. @romaninsh @ibelar what you think about this?

@mvorisek
Copy link
Member

closing in favor of atk4/ui#2070

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants