Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lister with JS paginator should still complete the initialization when scrolled (init/setOrder should not matter if called first or last) #1934

Open
mvorisek opened this issue Nov 2, 2022 · 0 comments

Comments

@mvorisek
Copy link
Member

mvorisek commented Nov 2, 2022

code to reproduce:

$crud = Crud::addTo($app);
$crud->setModel(new Country($app->db));
$crud->addJsPaginatorInContainer(20, 500 /* $containerHeight */);
$this->table->onRowClick(...);

the problem is addJsPaginatorInContainer terminates [1] the rendering and onRowClick is completely ignored when called from dynamic scroll AJAX

this problem poped out with #1932 fix where we unregister all events from original/non-AJAX load

[1] https://github.com/atk4/ui/blob/3.1.0/src/Lister.php#L122

@mvorisek mvorisek changed the title Lister with JS paginator should still complete the initialization when scrolled Lister with JS paginator should still complete the initialization when scrolled (init/setOrder should not matter if called first or last) Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant