Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FUI modal should be generated from php only #2229

Open
mvorisek opened this issue Nov 22, 2024 · 1 comment
Open

FUI modal should be generated from php only #2229

mvorisek opened this issue Nov 22, 2024 · 1 comment

Comments

@mvorisek
Copy link
Member

mvorisek commented Nov 22, 2024

Currently there are two locations where FUI modal is generated without php:

https://github.com/atk4/ui/blob/8a359e0975/js/src/JqueryPlugin/ConfirmPlugin.js
and
https://github.com/atk4/ui/blob/8a359e0975/js/src/JqueryPlugin/CreateModalPlugin.js

If there should be no roundtrip between client and server, they can be pregenerated, but never constructed within js only.

@mvorisek
Copy link
Member Author

As the JS calls should be coded from PHP only, I belive we should introduce something like "named JS code". We should however name it implicitly by its hash and ship it to the client only once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant