Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support React 18.x #108

Open
Aloushek opened this issue Aug 26, 2022 · 2 comments
Open

Support React 18.x #108

Aloushek opened this issue Aug 26, 2022 · 2 comments

Comments

@Aloushek
Copy link

Hello there,
we want to use this plugin but our project runs on [email protected]
Are there any plans to update dependencies (merge PRs) and release a new version with React 18 support?

@raminmz66
Copy link

Hi there,
We have also the same issue. I get the following dependency resolution error when installing storybook-addon-performance with [email protected]

npm ERR! Found: [email protected] npm ERR! node_modules/react npm ERR! react@"^18.2.0" from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer react@"^16.8.0 || ^17.0.0" from [email protected] npm ERR! node_modules/storybook-addon-performance npm ERR! dev storybook-addon-performance@"*" from the root project

@DarkPurple141
Copy link
Contributor

Hi folks 👋 - we're working on this - it's non-trivial to get this working as the way react itself works in v18 has shifted the way timings work. Thanks for your patience 🙏.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants