Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error reporting #180

Open
lukechilds opened this issue May 7, 2018 · 1 comment
Open

Better error reporting #180

lukechilds opened this issue May 7, 2018 · 1 comment
Labels
marketmaker v2 Not feasible until version 2 of marketmaker

Comments

@lukechilds
Copy link
Member

lukechilds commented May 7, 2018

We are limited to what we can do at the moment because marketmaker is inconsistent with how it reports errors and when when it does report error we very rarely get an error code to reference.

But we should do as much as we can to make the errors clearer wherever possible.

We're waiting on documentation for failed swap error codes: https://docs.google.com/spreadsheets/d/1blgmrJCZ-SfYaJdTTVdk717kZ43R4yzm9YIW2Bt--EM/edit#gid=0

Related:

@lukechilds lukechilds added this to the 0.1.0 milestone May 7, 2018
@sindresorhus sindresorhus modified the milestones: 0.1.0, Official launch May 22, 2018
@sindresorhus sindresorhus removed this from the Official launch milestone Jul 13, 2018
@sindresorhus sindresorhus added the marketmaker v2 Not feasible until version 2 of marketmaker label Jul 13, 2018
@jorian
Copy link

jorian commented Feb 26, 2020

Error reporting could be improved quite a bit with all the JSON responses that mm2.0 now returns. See the API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
marketmaker v2 Not feasible until version 2 of marketmaker
Projects
None yet
Development

No branches or pull requests

3 participants