Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'linux/limits.h' file not found breaking musl builds for c0.3.0 #1653

Closed
cpswan opened this issue Jan 14, 2025 · 4 comments
Closed

'linux/limits.h' file not found breaking musl builds for c0.3.0 #1653

cpswan opened this issue Jan 14, 2025 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@cpswan
Copy link
Member

cpswan commented Jan 14, 2025

Describe the bug

From the c0.3.0 (second attempt) build workflow where the musl builds fail with:

#9 30.91 [ 50%] Building C object _deps/atsdk-build/packages/atauth/CMakeFiles/atauth.dir/src/atauth_fetch_home_dir.c.o
#9 30.94 /sshnpd/sshnpd/build/_deps/atsdk-src/packages/atauth/src/atauth_fetch_home_dir.c:16:10: fatal error: 'linux/limits.h' file not found
#9 30.94    16 | #include <linux/limits.h>
#9 30.94       |          ^~~~~~~~~~~~~~~~
#9 30.94 1 error generated.

Steps to reproduce

  1. First I merged chore: update atsdk version #1649 to deal with the previous build failure Compiler warnings preventing musl builds for c0.3.0 #1648
  2. Then I re-release c0.3.0
  3. And then the build failed for a new reason - progress :)

Expected behavior

Build completes successfully and we get a release with a complete set of binaries etc.

@cpswan cpswan added the bug Something isn't working label Jan 14, 2025
@XavierChanth
Copy link
Member

Opened atsign-foundation/at_c#514 to address the issue

@cpswan
Copy link
Member Author

cpswan commented Jan 15, 2025

@XavierChanth are you now going to repoint the at_c tag so that we can do another attempt at c0.3.0?

@XavierChanth
Copy link
Member

Yes, I also want the atdirectory fix changes included

@XavierChanth
Copy link
Member

XavierChanth commented Jan 20, 2025

@cpswan can this be closed? This should be fixed in the latest build, I put conditionals in place to only include that header when it exists (otherwise we pick some sane fallback values for the constants we need from it)

@cpswan cpswan closed this as completed Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants