Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add npm run build for webapp to test suite #1687

Closed
cpswan opened this issue Jan 24, 2025 · 0 comments · Fixed by #1720
Closed

Add npm run build for webapp to test suite #1687

cpswan opened this issue Jan 24, 2025 · 0 comments · Fixed by #1720
Assignees
Labels
enhancement New feature or request

Comments

@cpswan
Copy link
Member

cpswan commented Jan 24, 2025

Is your feature request related to a problem? Please describe.

#1681 fails to build, but there's nothing in the tests to show that:

vite v6.0.11 building for production...
✓ 10 modules transformed.
x Build failed in 212ms
error during build:
[vite-plugin-svelte] [plugin vite-plugin-svelte] src/lib/PolicyUserGroups.svelte (521:52): src/lib/PolicyUserGroups.svelte:521:52 `<tr>` cannot be a child of `<table>`. `<table>` only allows these children: `<caption>`, `<colgroup>`, `<tbody>`, `<thead>`, `<tfoot>`, `<style>`, `<script>`, `<template>`. The browser will 'repair' the HTML (by moving, removing, or inserting elements) which breaks Svelte's assumptions about the structure of your components.
https://svelte.dev/e/node_invalid_placement
file: /home/chris/git/github.com/atsign-foundation/noports/apps/admin/webapp/src/lib/PolicyUserGroups.svelte:521:52

 519 |                                                      {/each}
 520 |                                                      </tbody>
 521 |                                                      <tr>
                                                                ^
 522 |                                                          <td>
 523 |                                                              <button type="button" class="btn btn-sm btn-outline-success" style="font-size:10px"

Describe the solution you'd like

Run npm run build on Dependabot PRs that modify webapp dependencies so that we can get an indication of whether they work or break.

@cpswan cpswan added the enhancement New feature or request label Jan 24, 2025
@cpswan cpswan assigned cpswan and gkc Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants