Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

problem reading utf8 filenames on windows #16

Open
andreprager opened this issue Mar 26, 2021 · 0 comments · May be fixed by #17
Open

problem reading utf8 filenames on windows #16

andreprager opened this issue Mar 26, 2021 · 0 comments · May be fixed by #17

Comments

@andreprager
Copy link

andreprager commented Mar 26, 2021 •
edited
Loading

I'm facing an issue reading waves from filenames containing chinese or other language specific characters. I'm using Visual Studio 2019 on Windows 10.
I made a local branch where I added std::wstring support, which at least solved the issue on my side.
I will now try to make a pull request (never did it before) so that you can review and hopefully merge it to main branch, so that others don't need to invest as much time as I did to find the cause of the issue.

Thanks a lot for the library so far, saved me some time, well done.
@maxmarsc maxmarsc linked a pull request Apr 14, 2021 that will close this issue
#16 added std::wstring support for filename. #17
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#16 added std::wstring support for filename. andreprager/wave
1 participant
@andreprager