-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add watch-namespaces to spicedb-operator cmd #331
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small comments. I'd also like to see a test for this (showing that the operator can't see objects in namespaces it hasn't been given access to) - let me know if that's something you think you can tackle; I can follow up with it later if needed.
@ecordell Thanks for the feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @sumedha-redd - let's go ahead and merge this and I'll follow up with a PR adding a test
#291 (comment)
Introduce
--watch-namespaces
argument to the spicedb-operator cmd, which accepts a comma-separated list of namespaces to watch. Update the controller to set up informers for each namespace. If the argument is not set, the operator continues to work at a cluster-wide level usingNamespaceAll
.