Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve DSN sync to handle continued syncing from non-canonical chain #1803

Closed
nazar-pc opened this issue Aug 11, 2023 · 0 comments · Fixed by #1807
Closed

Improve DSN sync to handle continued syncing from non-canonical chain #1803

nazar-pc opened this issue Aug 11, 2023 · 0 comments · Fixed by #1807
Assignees
@nazar-pc
Labels
bug Something isn't working core Related to core protocol, may affect fundamentals node Node (service library/node app)
Milestone
Secure Sync from DSN

Comments

@nazar-pc
Copy link
Member

It might happen such that node has one or more blocks that are not on canonical chain, but the rest of the blocks correspond to canonical chain.

In this case since DSN sync is only concerned with block numbers, it'll be unable to continue sync since parent block will not import. Essentially similar issue to paritytech/polkadot-sdk#493 (at least on high level).

We need to be able to kick in an alternative sub-mechanism that tries to download segments from a bit deeper history and import missing blocks from canonical chain if possible before resuming to sync from DSN the way we do it right now.
@nazar-pc nazar-pc added bug Something isn't working node Node (service library/node app) core Related to core protocol, may affect fundamentals labels Aug 11, 2023
@nazar-pc nazar-pc added this to the Secure Sync from DSN milestone Aug 11, 2023
@nazar-pc nazar-pc self-assigned this Aug 11, 2023
This was referenced Aug 12, 2023
Merged
Merged
@nazar-pc nazar-pc moved this from In Progress to Under Review in Subspace core (node, farmer, etc.) Aug 12, 2023
@nazar-pc nazar-pc linked a pull request Aug 14, 2023 that will close this issue
Fix DSN sync in case current canonical chain from the point of view of the node is different from canonical chain in archived history #1807
Merged
1 task
@github-project-automation github-project-automation bot moved this from Under Review to Closed in Subspace core (node, farmer, etc.) Aug 14, 2023
@nazar-pc nazar-pc mentioned this issue Sep 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nazar-pc nazar-pc

Labels
bug Something isn't working core Related to core protocol, may affect fundamentals node Node (service library/node app)
Projects
Subspace core (node, farmer, etc.)
Status: Closed
Milestone
Secure Sync from DSN
1 participant
@nazar-pc