From f1b9a53708f618966611a0ce6c26e8afae75939c Mon Sep 17 00:00:00 2001 From: "Takagi, Isamu" Date: Wed, 13 Dec 2023 10:30:09 +0900 Subject: [PATCH] docs(pull-request-guidelines): add notes of updating pull request branch Signed-off-by: Takagi, Isamu --- docs/contributing/pull-request-guidelines/index.md | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/contributing/pull-request-guidelines/index.md b/docs/contributing/pull-request-guidelines/index.md index a38a3618535..def73deb6ab 100644 --- a/docs/contributing/pull-request-guidelines/index.md +++ b/docs/contributing/pull-request-guidelines/index.md @@ -34,6 +34,7 @@ Use this workflow as a reference when you contribute to Autoware. - If you don't agree with a review comment, ask the reviewers for a rational reason. - The reviewers are obligated to make the author understand the meanings of each comment. - After you have done with the review comments, re-request a review to the reviewers and back to 6. + - Avoid using force push as much as possible so reviewers only see the differences. More precisely, at least keep a commit history up to the point of review because GitHub Web UI such as the the suggested change may require rebase to pass DCO CI. - If there are no more new review comments, the reviewers will approve the pull request and proceed to 8. 8. Merge the pull request. - Anyone with write access can merge the pull request if there is no special request from maintainers.