Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(motion_velocity_planner_common): fix the calc_possible_min_dist_from_obj_to_traj_poly calculation #10059

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

takayuki5168
Copy link
Contributor

Description

The calculation of calc_possible_min_dist_from_obj_to_traj_poly was wrong, and this PR fixed the issue.

Related links

How was this PR tested?

planning simulator & scenario tests

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 31, 2025
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 31, 2025
Copy link

github-actions bot commented Jan 31, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.30%. Comparing base (145f251) to head (0c4bcd6).

Files with missing lines Patch % Lines
...ion_velocity_planner_common_universe/src/utils.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10059      +/-   ##
==========================================
- Coverage   28.31%   28.30%   -0.01%     
==========================================
  Files        1484     1487       +3     
  Lines      111074   111102      +28     
  Branches    43144    43144              
==========================================
+ Hits        31447    31449       +2     
- Misses      76607    76635      +28     
+ Partials     3020     3018       -2     
Flag Coverage Δ *Carryforward flag
differential 13.98% <0.00%> (?)
total 28.31% <ø> (+<0.01%) ⬆️ Carriedforward from 145f251

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…rom_obj_to_traj_poly calculation

Signed-off-by: Takayuki Murooka <[email protected]>
Signed-off-by: Takayuki Murooka <[email protected]>
@takayuki5168 takayuki5168 force-pushed the fix/motion-velocity-calc_possible_min_dist_from_obj_to_traj_poly branch from 644c548 to 0c4bcd6 Compare January 31, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: To Triage
Development

Successfully merging this pull request may close these issues.

1 participant