-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new minimap overlay #7151
base: main
Are you sure you want to change the base?
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Current Progress, able to visualize both vehicle position and goal pose (mostly correctly) still unsure of why sometimes the calculations get wrong and with the zoom as well it gets very wrong needs improving |
@xmfcx @mitsudome-r It would error out like this, any ideas how to fix this ? there are a few things i need to add and they need both these messages also copyright messages are missing there are a few small details to be fixed |
common/autoware_overlay_rviz_plugin/autoware_minimap_overlay_rviz_plugin/CMakeLists.txt
Outdated
Show resolved
Hide resolved
common/autoware_overlay_rviz_plugin/autoware_minimap_overlay_rviz_plugin/CMakeLists.txt
Outdated
Show resolved
Hide resolved
common/autoware_overlay_rviz_plugin/autoware_minimap_overlay_rviz_plugin/package.xml
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7151 +/- ##
==========================================
- Coverage 28.76% 28.65% -0.12%
==========================================
Files 1592 1598 +6
Lines 116667 117115 +448
Branches 49937 49974 +37
==========================================
Hits 33554 33554
- Misses 74008 74456 +448
Partials 9105 9105
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
https://youtu.be/mKtN2YPag9w Latest updates including : vehicle position with orientation, trajectory drawn |
I think it is up for testing for whoever wants to try it.
|
int zone; | ||
bool north_p; | ||
double origin_lat = property_origin_lat_->getFloat(); | ||
double origin_lon = property_origin_lon_->getFloat(); | ||
double origin_x, origin_y, gamma, k; | ||
|
||
// Convert origin to UTM coordinates | ||
GeographicLib::UTMUPS::Forward( | ||
origin_lat, origin_lon, zone, north_p, origin_x, origin_y, gamma, k); | ||
|
||
// Calculate global UTM coordinates by adding local offsets | ||
double global_x = origin_x + x; | ||
double global_y = origin_y + y; | ||
|
||
// Convert back to geographic coordinates | ||
double lat, lon; | ||
GeographicLib::UTMUPS::Reverse(zone, north_p, global_x, global_y, lat, lon); | ||
|
||
return {lat, lon}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This projection depends on how the map is loaded in Autoware.
You should be able to retrieve the information from /map/map_projector_info topic and switch the projection to support different projection methods.
common/autoware_overlay_rviz_plugin/autoware_minimap_overlay_rviz_plugin/README.md
Show resolved
Hide resolved
Multiple Providers Demo : Is not committed as of now until confirmation of ToS if it allows the use of these providers being: OpenstreetMaps, ArcGIS satellite tiles and google maps hybrid tiles |
@xmfcx none of this is commited for now so it still is circular in the bottom left corner, there was a small conversation happening in the discord here : link
It was circular, this screenrecord here was to show armağan his suggestion of having it as a rounded square
It was in the bottom left, this screenrecord here was to show armağan his suggestion of having it on top right. |
I'm alright with users being able to select it by tuning radius to their liking. I was proposing to make it rounded rectangle with radius of height of the other overlays. All will have the same form. About the position, "Anchors" could be parameterized: AnchorHorizontal
AnchorVertical
Margins
I'm also aware of the conversation with @armaganarsln , regardless, it should not be adjacent to any corners, it should have the same margin as the other overlays. Looking at his suggestion, he also put it with margin from the edges too. |
Yeah, me too i think this would a good addition as well. I can either open a new PR for it separately for the other 2 already existing overlays or wait until this PR is approved and add it at the end of it and merge only 1 PR with all the changes for extracting the Margins and Anchor positions
Yeah looks like it, on the meeting call he said something about having it stick to the edges that's why i had made it that way when sharing the demo of what it would look like. |
We can start working on the others once this one is finished and merged. |
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
…goalpose Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
…path Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com>
…viz_plugin/src/minimap.cpp Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com>
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
…origin_lat and origin_lon parameters Signed-off-by: KhalilSelyan <khalil@leodrive.ai>
06682c2
to
fd87102
Compare
@mitsudome-r Will finish the review. |
Description
This PR introduces a minimap plugin for RViz, designed to provide a 2D overlay of the map within the RViz interface. The plugin leverages Qt and 2D overlay utilities to display map tiles based on GPS coordinates, enhancing situational awareness for users.
Related links
Tests performed
Notes for reviewers
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.