Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_tensorrt_rtmdet): add tensorrt rtmdet model #8165

Open
wants to merge 82 commits into
base: main
Choose a base branch
from

refactor(autoware_tensorrt_rtmdet): upgrade to new autoware_tensorrt_…

f744a8a
Select commit
Loading
Failed to load commit list.
Open

feat(autoware_tensorrt_rtmdet): add tensorrt rtmdet model #8165

refactor(autoware_tensorrt_rtmdet): upgrade to new autoware_tensorrt_…
f744a8a
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Jan 27, 2025 in 41s

CodeScene PR Check

Code Health Quality Gates: FAILED

Code Health of new files: 8.54

  • Declining Code Health: 10 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Conditional tensorrt_rtmdet_node.cpp: TrtRTMDetNode::on_connect
  • Overall Code Complexity tensorrt_rtmdet.cpp
  • Deep, Nested Complexity tensorrt_rtmdet.cpp: TrtRTMDet::preprocess_gpu
  • Complex Method tensorrt_rtmdet_node.cpp: TrtRTMDetNode::on_image
  • Complex Conditional test_rtmdet.cpp: get_pixel_value
  • Large Method tensorrt_rtmdet.cpp: TrtRTMDet::feedforward
  • Complex Method tensorrt_rtmdet.cpp: TrtRTMDet::preprocess_gpu
  • Bumpy Road Ahead tensorrt_rtmdet.cpp: TrtRTMDet::preprocess_gpu
  • Bumpy Road Ahead tensorrt_rtmdet.cpp: TrtRTMDet::feedforward
  • Bumpy Road Ahead tensorrt_rtmdet.cpp: TrtRTMDet::nms_sorted_bboxes

Annotations

Check warning on line 221 in perception/autoware_tensorrt_rtmdet/src/tensorrt_rtmdet.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

TrtRTMDet::preprocess_gpu has a cyclomatic complexity of 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 321 in perception/autoware_tensorrt_rtmdet/src/tensorrt_rtmdet.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Large Method

TrtRTMDet::feedforward has 75 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check warning on line 221 in perception/autoware_tensorrt_rtmdet/src/tensorrt_rtmdet.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

TrtRTMDet::preprocess_gpu has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 321 in perception/autoware_tensorrt_rtmdet/src/tensorrt_rtmdet.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

TrtRTMDet::feedforward has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 361 in perception/autoware_tensorrt_rtmdet/src/tensorrt_rtmdet.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Bumpy Road Ahead

TrtRTMDet::nms_sorted_bboxes has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 1 in perception/autoware_tensorrt_rtmdet/src/tensorrt_rtmdet.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Overall Code Complexity

This module has a mean cyclomatic complexity of 4.75 across 8 functions. The mean complexity threshold is 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.

Check warning on line 221 in perception/autoware_tensorrt_rtmdet/src/tensorrt_rtmdet.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Deep, Nested Complexity

TrtRTMDet::preprocess_gpu has a nested complexity depth of 4, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.

Check warning on line 205 in perception/autoware_tensorrt_rtmdet/src/tensorrt_rtmdet_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

TrtRTMDetNode::on_image has a cyclomatic complexity of 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 104 in perception/autoware_tensorrt_rtmdet/src/tensorrt_rtmdet_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Conditional

TrtRTMDetNode::on_connect has 1 complex conditionals with 5 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.

Check warning on line 37 in perception/autoware_tensorrt_rtmdet/test/test_rtmdet.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Conditional

get_pixel_value has 1 complex conditionals with 3 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.