From 93d32a0cd44561dcf0404bdf7e3ac3f287c46931 Mon Sep 17 00:00:00 2001 From: Junya Sasaki Date: Mon, 20 Jan 2025 17:41:10 +0900 Subject: [PATCH 1/5] feat(bag_time_manager_rviz_plugin): apply `autoware_` prefix (see below): Note: * In this commit, I did not organize a folder structure. The folder structure will be organized in the next some commits. * The changes will follow the Autoware's guideline as below: - https://autowarefoundation.github.io/autoware-documentation/main/contributing/coding-guidelines/ros-nodes/directory-structure/#package-folder Signed-off-by: Junya Sasaki --- .../bag_time_manager_rviz_plugin/CMakeLists.txt | 2 +- .../bag_time_manager_rviz_plugin/package.xml | 3 ++- .../plugins/plugin_description.xml | 2 +- .../src/bag_time_manager_panel.cpp | 8 ++++---- .../src/bag_time_manager_panel.hpp | 12 ++++++------ 5 files changed, 14 insertions(+), 13 deletions(-) diff --git a/visualization/bag_time_manager_rviz_plugin/CMakeLists.txt b/visualization/bag_time_manager_rviz_plugin/CMakeLists.txt index ccf9961fc55cc..5ee02349f7d96 100644 --- a/visualization/bag_time_manager_rviz_plugin/CMakeLists.txt +++ b/visualization/bag_time_manager_rviz_plugin/CMakeLists.txt @@ -1,5 +1,5 @@ cmake_minimum_required(VERSION 3.14) -project(bag_time_manager_rviz_plugin) +project(autoware_bag_time_manager_rviz_plugin) find_package(autoware_cmake REQUIRED) autoware_package() diff --git a/visualization/bag_time_manager_rviz_plugin/package.xml b/visualization/bag_time_manager_rviz_plugin/package.xml index 365dad286d22c..916d1b4674620 100644 --- a/visualization/bag_time_manager_rviz_plugin/package.xml +++ b/visualization/bag_time_manager_rviz_plugin/package.xml @@ -1,10 +1,11 @@ - bag_time_manager_rviz_plugin + autoware_bag_time_manager_rviz_plugin 0.40.0 Rviz plugin to publish and control the ros bag Taiki Tanaka + Junya Sasaki Apache License 2.0 ament_cmake_auto diff --git a/visualization/bag_time_manager_rviz_plugin/plugins/plugin_description.xml b/visualization/bag_time_manager_rviz_plugin/plugins/plugin_description.xml index 2a3bbf667b715..959ce30b2ba6a 100644 --- a/visualization/bag_time_manager_rviz_plugin/plugins/plugin_description.xml +++ b/visualization/bag_time_manager_rviz_plugin/plugins/plugin_description.xml @@ -1,7 +1,7 @@ Panel that publishes a service to modify its speed. diff --git a/visualization/bag_time_manager_rviz_plugin/src/bag_time_manager_panel.cpp b/visualization/bag_time_manager_rviz_plugin/src/bag_time_manager_panel.cpp index cae9660b51266..bf90aeb0e465e 100644 --- a/visualization/bag_time_manager_rviz_plugin/src/bag_time_manager_panel.cpp +++ b/visualization/bag_time_manager_rviz_plugin/src/bag_time_manager_panel.cpp @@ -1,5 +1,5 @@ // -// Copyright 2022 Tier IV, Inc. All rights reserved. +// Copyright 2025 Tier IV, Inc. All rights reserved. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. @@ -23,7 +23,7 @@ #include -namespace rviz_plugins +namespace autoware::visualization::bag_time_manager_rviz_plugin { BagTimeManagerPanel::BagTimeManagerPanel(QWidget * parent) : rviz_common::Panel(parent) { @@ -111,7 +111,7 @@ void BagTimeManagerPanel::onApplyRateClicked() } }); } -} // namespace rviz_plugins +} // namespace autoware::visualization::bag_time_manager_rviz_plugin #include -PLUGINLIB_EXPORT_CLASS(rviz_plugins::BagTimeManagerPanel, rviz_common::Panel) +PLUGINLIB_EXPORT_CLASS(autoware::visualization::bag_time_manager_rviz_plugin::BagTimeManagerPanel, rviz_common::Panel) diff --git a/visualization/bag_time_manager_rviz_plugin/src/bag_time_manager_panel.hpp b/visualization/bag_time_manager_rviz_plugin/src/bag_time_manager_panel.hpp index 2cc4b98a6dabf..6f5cf34880e96 100644 --- a/visualization/bag_time_manager_rviz_plugin/src/bag_time_manager_panel.hpp +++ b/visualization/bag_time_manager_rviz_plugin/src/bag_time_manager_panel.hpp @@ -1,5 +1,5 @@ // -// Copyright 2022 Tier IV, Inc. All rights reserved. +// Copyright 2025 Tier IV, Inc. All rights reserved. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. @@ -14,8 +14,8 @@ // limitations under the License. // -#ifndef BAG_TIME_MANAGER_PANEL_HPP_ -#define BAG_TIME_MANAGER_PANEL_HPP_ +#ifndef AUTOWARE__VISUALIZATION__BAG_TIME_MANAGER_RVIZ_PLUGIN__BAG_TIME_MANAGER_PANEL_HPP_ +#define AUTOWARE__VISUALIZATION__BAG_TIME_MANAGER_RVIZ_PLUGIN__BAG_TIME_MANAGER_PANEL_HPP_ #include #include @@ -29,7 +29,7 @@ #include #include -namespace rviz_plugins +namespace autoware::visualization::bag_time_manager_rviz_plugin { using rosbag2_interfaces::srv::Pause; using rosbag2_interfaces::srv::Resume; @@ -67,6 +67,6 @@ protected Q_SLOTS: STATE current_state_{RESUME}; }; -} // namespace rviz_plugins +} // namespace autoware::visualization::bag_time_manager_rviz_plugin -#endif // BAG_TIME_MANAGER_PANEL_HPP_ +#endif // AUTOWARE__VISUALIZATION__BAG_TIME_MANAGER_RVIZ_PLUGIN__BAG_TIME_MANAGER_PANEL_HPP_ From 7506580bc245464e0b26abda008f4539cfc8761e Mon Sep 17 00:00:00 2001 From: Junya Sasaki Date: Mon, 20 Jan 2025 17:46:50 +0900 Subject: [PATCH 2/5] rename: `bag_time_manager_rviz_plugin` => `autoware_bag_time_manager_rviz_plugin` Signed-off-by: Junya Sasaki --- .../CHANGELOG.rst | 0 .../CMakeLists.txt | 0 .../README.md | 0 .../icons/classes/BagTimeManagerPanel.png | Bin .../images/add_bag_time_manager_panel.png | Bin .../images/bag_time_manager_panel.png | Bin .../images/select_panels.png | Bin .../package.xml | 0 .../plugins/plugin_description.xml | 0 .../src/bag_time_manager_panel.cpp | 0 .../src/bag_time_manager_panel.hpp | 0 11 files changed, 0 insertions(+), 0 deletions(-) rename visualization/{bag_time_manager_rviz_plugin => autoware_bag_time_manager_rviz_plugin}/CHANGELOG.rst (100%) rename visualization/{bag_time_manager_rviz_plugin => autoware_bag_time_manager_rviz_plugin}/CMakeLists.txt (100%) rename visualization/{bag_time_manager_rviz_plugin => autoware_bag_time_manager_rviz_plugin}/README.md (100%) rename visualization/{bag_time_manager_rviz_plugin => autoware_bag_time_manager_rviz_plugin}/icons/classes/BagTimeManagerPanel.png (100%) rename visualization/{bag_time_manager_rviz_plugin => autoware_bag_time_manager_rviz_plugin}/images/add_bag_time_manager_panel.png (100%) rename visualization/{bag_time_manager_rviz_plugin => autoware_bag_time_manager_rviz_plugin}/images/bag_time_manager_panel.png (100%) rename visualization/{bag_time_manager_rviz_plugin => autoware_bag_time_manager_rviz_plugin}/images/select_panels.png (100%) rename visualization/{bag_time_manager_rviz_plugin => autoware_bag_time_manager_rviz_plugin}/package.xml (100%) rename visualization/{bag_time_manager_rviz_plugin => autoware_bag_time_manager_rviz_plugin}/plugins/plugin_description.xml (100%) rename visualization/{bag_time_manager_rviz_plugin => autoware_bag_time_manager_rviz_plugin}/src/bag_time_manager_panel.cpp (100%) rename visualization/{bag_time_manager_rviz_plugin => autoware_bag_time_manager_rviz_plugin}/src/bag_time_manager_panel.hpp (100%) diff --git a/visualization/bag_time_manager_rviz_plugin/CHANGELOG.rst b/visualization/autoware_bag_time_manager_rviz_plugin/CHANGELOG.rst similarity index 100% rename from visualization/bag_time_manager_rviz_plugin/CHANGELOG.rst rename to visualization/autoware_bag_time_manager_rviz_plugin/CHANGELOG.rst diff --git a/visualization/bag_time_manager_rviz_plugin/CMakeLists.txt b/visualization/autoware_bag_time_manager_rviz_plugin/CMakeLists.txt similarity index 100% rename from visualization/bag_time_manager_rviz_plugin/CMakeLists.txt rename to visualization/autoware_bag_time_manager_rviz_plugin/CMakeLists.txt diff --git a/visualization/bag_time_manager_rviz_plugin/README.md b/visualization/autoware_bag_time_manager_rviz_plugin/README.md similarity index 100% rename from visualization/bag_time_manager_rviz_plugin/README.md rename to visualization/autoware_bag_time_manager_rviz_plugin/README.md diff --git a/visualization/bag_time_manager_rviz_plugin/icons/classes/BagTimeManagerPanel.png b/visualization/autoware_bag_time_manager_rviz_plugin/icons/classes/BagTimeManagerPanel.png similarity index 100% rename from visualization/bag_time_manager_rviz_plugin/icons/classes/BagTimeManagerPanel.png rename to visualization/autoware_bag_time_manager_rviz_plugin/icons/classes/BagTimeManagerPanel.png diff --git a/visualization/bag_time_manager_rviz_plugin/images/add_bag_time_manager_panel.png b/visualization/autoware_bag_time_manager_rviz_plugin/images/add_bag_time_manager_panel.png similarity index 100% rename from visualization/bag_time_manager_rviz_plugin/images/add_bag_time_manager_panel.png rename to visualization/autoware_bag_time_manager_rviz_plugin/images/add_bag_time_manager_panel.png diff --git a/visualization/bag_time_manager_rviz_plugin/images/bag_time_manager_panel.png b/visualization/autoware_bag_time_manager_rviz_plugin/images/bag_time_manager_panel.png similarity index 100% rename from visualization/bag_time_manager_rviz_plugin/images/bag_time_manager_panel.png rename to visualization/autoware_bag_time_manager_rviz_plugin/images/bag_time_manager_panel.png diff --git a/visualization/bag_time_manager_rviz_plugin/images/select_panels.png b/visualization/autoware_bag_time_manager_rviz_plugin/images/select_panels.png similarity index 100% rename from visualization/bag_time_manager_rviz_plugin/images/select_panels.png rename to visualization/autoware_bag_time_manager_rviz_plugin/images/select_panels.png diff --git a/visualization/bag_time_manager_rviz_plugin/package.xml b/visualization/autoware_bag_time_manager_rviz_plugin/package.xml similarity index 100% rename from visualization/bag_time_manager_rviz_plugin/package.xml rename to visualization/autoware_bag_time_manager_rviz_plugin/package.xml diff --git a/visualization/bag_time_manager_rviz_plugin/plugins/plugin_description.xml b/visualization/autoware_bag_time_manager_rviz_plugin/plugins/plugin_description.xml similarity index 100% rename from visualization/bag_time_manager_rviz_plugin/plugins/plugin_description.xml rename to visualization/autoware_bag_time_manager_rviz_plugin/plugins/plugin_description.xml diff --git a/visualization/bag_time_manager_rviz_plugin/src/bag_time_manager_panel.cpp b/visualization/autoware_bag_time_manager_rviz_plugin/src/bag_time_manager_panel.cpp similarity index 100% rename from visualization/bag_time_manager_rviz_plugin/src/bag_time_manager_panel.cpp rename to visualization/autoware_bag_time_manager_rviz_plugin/src/bag_time_manager_panel.cpp diff --git a/visualization/bag_time_manager_rviz_plugin/src/bag_time_manager_panel.hpp b/visualization/autoware_bag_time_manager_rviz_plugin/src/bag_time_manager_panel.hpp similarity index 100% rename from visualization/bag_time_manager_rviz_plugin/src/bag_time_manager_panel.hpp rename to visualization/autoware_bag_time_manager_rviz_plugin/src/bag_time_manager_panel.hpp From 89e997650adfd763f9f7a28a6aacb1d89ca666f8 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Mon, 20 Jan 2025 08:53:54 +0000 Subject: [PATCH 3/5] style(pre-commit): autofix --- .../src/bag_time_manager_panel.cpp | 3 ++- .../src/bag_time_manager_panel.hpp | 6 +++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/visualization/autoware_bag_time_manager_rviz_plugin/src/bag_time_manager_panel.cpp b/visualization/autoware_bag_time_manager_rviz_plugin/src/bag_time_manager_panel.cpp index bf90aeb0e465e..7ab003e2880de 100644 --- a/visualization/autoware_bag_time_manager_rviz_plugin/src/bag_time_manager_panel.cpp +++ b/visualization/autoware_bag_time_manager_rviz_plugin/src/bag_time_manager_panel.cpp @@ -114,4 +114,5 @@ void BagTimeManagerPanel::onApplyRateClicked() } // namespace autoware::visualization::bag_time_manager_rviz_plugin #include -PLUGINLIB_EXPORT_CLASS(autoware::visualization::bag_time_manager_rviz_plugin::BagTimeManagerPanel, rviz_common::Panel) +PLUGINLIB_EXPORT_CLASS( + autoware::visualization::bag_time_manager_rviz_plugin::BagTimeManagerPanel, rviz_common::Panel) diff --git a/visualization/autoware_bag_time_manager_rviz_plugin/src/bag_time_manager_panel.hpp b/visualization/autoware_bag_time_manager_rviz_plugin/src/bag_time_manager_panel.hpp index 6f5cf34880e96..710d20046a548 100644 --- a/visualization/autoware_bag_time_manager_rviz_plugin/src/bag_time_manager_panel.hpp +++ b/visualization/autoware_bag_time_manager_rviz_plugin/src/bag_time_manager_panel.hpp @@ -14,8 +14,8 @@ // limitations under the License. // -#ifndef AUTOWARE__VISUALIZATION__BAG_TIME_MANAGER_RVIZ_PLUGIN__BAG_TIME_MANAGER_PANEL_HPP_ -#define AUTOWARE__VISUALIZATION__BAG_TIME_MANAGER_RVIZ_PLUGIN__BAG_TIME_MANAGER_PANEL_HPP_ +#ifndef BAG_TIME_MANAGER_PANEL_HPP_ +#define BAG_TIME_MANAGER_PANEL_HPP_ #include #include @@ -69,4 +69,4 @@ protected Q_SLOTS: } // namespace autoware::visualization::bag_time_manager_rviz_plugin -#endif // AUTOWARE__VISUALIZATION__BAG_TIME_MANAGER_RVIZ_PLUGIN__BAG_TIME_MANAGER_PANEL_HPP_ +#endif // BAG_TIME_MANAGER_PANEL_HPP_ From 7a02572a39606dfad53800be759f818ff386033b Mon Sep 17 00:00:00 2001 From: Junya Sasaki Date: Tue, 21 Jan 2025 14:10:07 +0900 Subject: [PATCH 4/5] Update visualization/autoware_bag_time_manager_rviz_plugin/plugins/plugin_description.xml Signed-off-by: Junya Sasaki Co-authored-by: SakodaShintaro --- .../plugins/plugin_description.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/visualization/autoware_bag_time_manager_rviz_plugin/plugins/plugin_description.xml b/visualization/autoware_bag_time_manager_rviz_plugin/plugins/plugin_description.xml index 959ce30b2ba6a..f8c678a75b4ee 100644 --- a/visualization/autoware_bag_time_manager_rviz_plugin/plugins/plugin_description.xml +++ b/visualization/autoware_bag_time_manager_rviz_plugin/plugins/plugin_description.xml @@ -1,4 +1,4 @@ - + Date: Wed, 22 Jan 2025 23:22:22 +0900 Subject: [PATCH 5/5] docs(autoware_bag_time_manager_rviz_plugin): update package name in README and CHANGLOG.rst Signed-off-by: Ryohsuke Mitsudome --- .../autoware_bag_time_manager_rviz_plugin/CHANGELOG.rst | 6 +++--- .../autoware_bag_time_manager_rviz_plugin/README.md | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/visualization/autoware_bag_time_manager_rviz_plugin/CHANGELOG.rst b/visualization/autoware_bag_time_manager_rviz_plugin/CHANGELOG.rst index df222e8eb584e..b9a32e20f76c4 100644 --- a/visualization/autoware_bag_time_manager_rviz_plugin/CHANGELOG.rst +++ b/visualization/autoware_bag_time_manager_rviz_plugin/CHANGELOG.rst @@ -1,6 +1,6 @@ -^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ -Changelog for package bag_time_manager_rviz_plugin -^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ +Changelog for package autoware_bag_time_manager_rviz_plugin +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 0.40.0 (2024-12-12) ------------------- diff --git a/visualization/autoware_bag_time_manager_rviz_plugin/README.md b/visualization/autoware_bag_time_manager_rviz_plugin/README.md index 2fad6b2204bb9..58d81d06dffa4 100644 --- a/visualization/autoware_bag_time_manager_rviz_plugin/README.md +++ b/visualization/autoware_bag_time_manager_rviz_plugin/README.md @@ -1,4 +1,4 @@ -# bag_time_manager_rviz_plugin +# autoware_bag_time_manager_rviz_plugin ## Purpose