Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate the .repos in the sample packages and split them into a separate container #5075

Open
youtalk opened this issue Aug 13, 2024 · 1 comment
Labels
component:openadkit Issues or Features related to Open AD Kit type:containers Docker containers, containerization of components, or container orchestration.

Comments

@youtalk
Copy link
Member

youtalk commented Aug 13, 2024

https://github.com/autowarefoundation/autoware/blob/main/autoware.repos currently includes many packages meant for sample code, such as tamagawa_imu_driver and sample_sensor_kit_launch.
First, manage these packages with a separate .repos file.

Next, create a separate container image that includes only these packages, which will help reduce the size of the main container and improve availability.

@youtalk youtalk added type:containers Docker containers, containerization of components, or container orchestration. component:openadkit Issues or Features related to Open AD Kit labels Aug 13, 2024
@xmfcx
Copy link
Contributor

xmfcx commented Feb 5, 2025

  • sample_sensor_kit_launch
  • sample_vehicle_launch
  • autoware_individual_params

These are required for running the tutorials. If these are separated, we should update the documentation with steps to pull these too.

But my concern is, .repos files are already very fragmented. Developers now have to pull more and more .repos files and I'd prefer if we could maintain a comprehensive .repos file for developers.

I agree with moving tamagawa_imu_driver and pacmod_interface out as vendor specific packages. But not for the repositories that contain things required for the demos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:openadkit Issues or Features related to Open AD Kit type:containers Docker containers, containerization of components, or container orchestration.
Projects
None yet
Development

No branches or pull requests

2 participants