Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log in via GitHub #8

Open
reinh opened this issue Apr 11, 2013 · 3 comments
Open

Log in via GitHub #8

reinh opened this issue Apr 11, 2013 · 3 comments

Comments

@reinh
Copy link

reinh commented Apr 11, 2013

As a user
So that I can participate
I want to log in using my GitHub account

@avdi
Copy link
Owner

avdi commented Apr 11, 2013

Definitely, but I want to see this be a dependency of one of the features that requires it.

@akston
Copy link
Contributor

akston commented Apr 26, 2013

Hey guys, newbie here. I would like to try my hand at implementing this feature, but I have a couple questions/concerns:

  • Since you would not want to roll it out until there's another feature that requires it, would I be wasting my time, or could conflicts be resolved and my code be merged into the codebase to complete the full feature?
  • What is the preferred method of handling API keys for the omniauth configuration (e.g: local_env.yml, figaro, etc.)?

Thanks!

@akston
Copy link
Contributor

akston commented May 11, 2013

I've implemented this feature, but I'll wait until it's needed to open a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants