You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello!
I seem to have found an inconsistency in the implementation of rate aggregation for counters.
Bioyino calculates rate as "counts per sec", while statsd implies "value per sec"
Not to be confused with timer's count_ps in statsd (also called rate in bioyino) - it's different aggregation
Hello!
I seem to have found an inconsistency in the implementation of rate aggregation for counters.
Bioyino calculates rate as "counts per sec", while statsd implies "value per sec"
Not to be confused with timer's count_ps in statsd (also called rate in bioyino) - it's different aggregation
Can we make it compatible with statsd?
https://github.com/statsd/statsd/blob/7c07eec4e7cebbd376d8313b230cea96c6571423/lib/process_metrics.js#L19
How to reproduce:
statsd
bioyino
Samples:
Results:
statsd
bioyino
As we see test.counter.rate uses different logic to calculate.
I see that rate was asked ealier in issue #37
as
but implemented only
Later we discussed rate in implementation of sample rate
#53 (comment)
My fault for not checking rate for counter
The text was updated successfully, but these errors were encountered: