Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for dgraph-io/badger #91

Closed
Olex1313 opened this issue Dec 1, 2023 · 4 comments
Closed

Support for dgraph-io/badger #91

Olex1313 opened this issue Dec 1, 2023 · 4 comments

Comments

@Olex1313
Copy link

Olex1313 commented Dec 1, 2023

Hello, I've wanted to add support for https://github.com/dgraph-io/badger, but most recent badger/v4 uses go 1.19, and trm is 1.13 due to backward compatibility. So I have a few questions

  1. will go-transaction-manager bump its go version someday?
  2. How can I contribute with badger support without bumping go version? I am aming for supporting badger/v4, maybe with separate it with build-tags?
  3. Could I fork go-transaction-manager for my personal usage and bump go there?
@maranqz
Copy link
Member

maranqz commented Dec 2, 2023

Hello,

  1. I am not planning to bump the version.
  2. You can see the gorm example, which supports only going 1.16 and up by build tags.
  3. I cannot forbid you to fork. It is your right :) However, I suggest you use the gorm approach to add badger in go-transaction-manager.

I want to separate the interface and implementation in different go.mod packages. When it would be done, I don't know.
There is an issue with that #75

@Olex1313
Copy link
Author

Olex1313 commented Dec 4, 2023

Okay, maybe I will start separation mentioned in #75, but only for badger for now?

@maranqz
Copy link
Member

maranqz commented Dec 4, 2023

Yes, you can continue my pr or review it.
#92

#96

@maranqz
Copy link
Member

maranqz commented Sep 21, 2024

If you have a desire to contribute, reopen the issues and feel free to create a PR.

@maranqz maranqz closed this as completed Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants