Country and state leaderboards bugs

[alexcwatt]

@Nateowami posted this bug report. (Feel free to open GH issues in the future.)

Additionally, I'm seeing that all the states are pulling up Alabama. It's obviously a caching issue, and possibly the country problem is a caching issue also.

[alexcwatt]

@Nateowami The 404 errors are almost resolved. You are correct that it is counting active and inactive users; this is something to fix.

I will let @avitus weigh in on counting active + inactive in the "Uses" column on the countryboard. It's been that way for a long time (possibly "forever").

[Nateowami]

Some more oddities (that I just noticed) are:

• Church and Group leaderboards say they need "three members." US state and country leaderboards say they need "three active members." I didn't check if the system follows for these claims.
• The referalboard does not say if you need to be active to appear on it (it only talks about your referrals being active/inactive and how they are counted). Rather minor.
• The group leaderboards (meaning, ranking members of a group, not the groups themselves) show inactive and active members. The country leaderboards look like they require you to be active to be shown, but then list you as "active," which would be redundant. The US states do the same. And... so do the church leaderboards.

I don't think any of this should be hard to fix though. How exactly it should be done is another question.

[Nateowami]

Another somewhat-minor issue is that at multiple churches are showing as 70^ith. See churches 387 & 1548. I'm not aware that it's causing much of a problem, but I thought I'd add it here.

[Nateowami]

Steven Duncan has pointed out that the number of users listed on the group and church leaderboards is inaccurate. At first I thought it must be an active/inactive discrepancy, but the group leaderboards list all users, active or not.

For example, see 10. Independent Fundamental Baptist. It lists 10 users (4 inactive), but the group leaderboard says there are 16.