Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HTML comments from emails #325

Open
alexcwatt opened this issue Aug 17, 2016 · 0 comments
Open

Remove HTML comments from emails #325

alexcwatt opened this issue Aug 17, 2016 · 0 comments
Assignees

Comments

@alexcwatt
Copy link
Collaborator

alexcwatt commented Aug 17, 2016

These come through in some clients (e.g., FastMail — and I think I've seen it in Outlook too):

image

If we need comments, it's probably best to do them Ruby-style:

<% # Comment here, which will never come through in generated view %>

But I think we can just delete these comments. Or maybe we can leave them and do some processing where we remove them before sending the email.

@alexcwatt alexcwatt self-assigned this Aug 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant