Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When user rejects reset sync, do not further continue #1269

Closed
Tracked by #1538
petmongrels opened this issue Jan 8, 2024 · 4 comments
Closed
Tracked by #1538

When user rejects reset sync, do not further continue #1269

petmongrels opened this issue Jan 8, 2024 · 4 comments
Assignees

Comments

@petmongrels
Copy link
Contributor

petmongrels commented Jan 8, 2024

Need:

  • Making sure all necessary cases handled
  • We have got cases where individual's address level has not synced. One rootcause could be this.

Context:

  • The ability to ignore reset was added when users are in a place without good internet connection.
  • Currently we are continuing to sync with the changed users catchment without syncing from beginning when user ignores reset sync. This will lead to association error issues and one mentioned below.

Steps to reproduce:

  • synced with maha@rwb24uat with test_maha catchment
  • Changed the catchment to test_maha_new catchment
  • Ignored to reset
  • Got the error 'lowestAddressLevel Mandatory for Individual...' error.

Acceptance criteria:

  • When the user presses 'No' dont proceed with further sync of pulling data.

Clarifications:

  • Data push should continue to happen before checking for reset sync like done currently.
  • No need to change the user confirmation message since as of now no one has reported any confusion.

Testing QA notes:

  • Test for all cases mentioned here
@petmongrels petmongrels converted this from a draft issue Jan 8, 2024
@mahalakshme
Copy link
Contributor

mahalakshme commented Mar 8, 2024

@petmongrels why do we need mechanism to turn off reset sync for any user - U ve mentioned this: 'we have no mechanism to turn of reset sync for any user'. There would be issues if turnedoff no? - moved the line to this card: #1339

@mahalakshme mahalakshme changed the title Relook at the logic for reset sync and fast sync Remove the ability for user to be able to ignore reset sync Mar 8, 2024
@petmongrels
Copy link
Contributor Author

The confusing part is - why is the option given to user to choose to ignore reset sync?

@mahalakshme
Copy link
Contributor

@petmongrels yeah it should not have been given, so ve prioritised this - this card: https://app.zenhub.com/workspaces/avni-product-deprecated-635b73bded85e50018871ae6/issues/gh/avniproject/avni-server/369 - says its because some users could ve poor internet connection.

@mahalakshme mahalakshme moved this from New Issues to Ready in Avni Product Mar 12, 2024
@mahalakshme mahalakshme changed the title Remove the ability for user to be able to ignore reset sync When user rejects to reset sync, do not further continue Mar 12, 2024
@mahalakshme mahalakshme changed the title When user rejects to reset sync, do not further continue When user rejects reset sync, do not further continue Mar 12, 2024
@1t5j0y 1t5j0y moved this from Ready to In Progress in Avni Product Mar 13, 2024
@1t5j0y 1t5j0y self-assigned this Mar 13, 2024
1t5j0y added a commit that referenced this issue Mar 13, 2024
@1t5j0y 1t5j0y moved this from In Progress to Code Review Ready in Avni Product Mar 13, 2024
@petmongrels petmongrels moved this from Code Review Ready to In Code Review in Avni Product Mar 22, 2024
@petmongrels petmongrels moved this from In Code Review to QA Ready in Avni Product Mar 22, 2024
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Jun 5, 2024
@AchalaBelokar AchalaBelokar moved this from In QA to QA Ready in Avni Product Jun 11, 2024
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Jun 20, 2024
@AchalaBelokar AchalaBelokar moved this from In QA to QA Failed in Avni Product Jun 20, 2024
@1t5j0y 1t5j0y moved this from QA Failed to In Progress in Avni Product Jun 20, 2024
@1t5j0y
Copy link
Contributor

1t5j0y commented Jun 20, 2024

@AchalaBelokar the locations added / removed from a catchment need to have some subjects registered for reset sync record to get created for the user in that catchment.

@1t5j0y 1t5j0y moved this from In Progress to QA Ready in Avni Product Jun 20, 2024
@AchalaBelokar AchalaBelokar moved this from QA Ready to Done in Avni Product Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants