Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type Cast error during sync of Distribution to Salesforce #1353

Closed
mahalakshme opened this issue Mar 28, 2024 · 3 comments
Closed

Type Cast error during sync of Distribution to Salesforce #1353

mahalakshme opened this issue Mar 28, 2024 · 3 comments
Assignees

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Mar 28, 2024

https://avni.freshdesk.com/a/tickets/3697

Wanted to add a card, since we know what is fixed as part of release, tickets are more for providing workarounds etc.,

@himeshr himeshr self-assigned this Mar 28, 2024
@himeshr
Copy link
Contributor

himeshr commented Mar 28, 2024

Analysis

The goonj Distribution form considers the "Total Number of Families Reached" concept to be a Numeric Concept and its used in FormElement "Total Number of Families Reached", which is marked as a Mandatory field.

There are additional validation rule that this value cannot be zero.

For some reason, i see that User was able to insert a value of ".0" for this field and sync, which has resulted in this cast exception.

Further action

  • There is no issue to be fixed with the integration code, but rather a fix needed on the avni-client to avoid this sort of data issue in future.
  • Also, make the correction in data for distribution with uuid "b056f016-ea8d-4539-8dc8-249719efba12" to have the value as 1 for this concept and allow sync to complete successfully.

@himeshr himeshr transferred this issue from avniproject/integration-service Mar 28, 2024
himeshr added a commit to avniproject/avni-models that referenced this issue Mar 28, 2024
@himeshr himeshr moved this from In Progress to Code Review Ready in Avni Product Mar 28, 2024
@himeshr
Copy link
Contributor

himeshr commented Apr 2, 2024

As part of dev-testing, confirmed that the value stored in observations for a input value of .012 would be numeric value 0.012 after this fix, which wasn't the case earlier. It was stored as string value ".012" before this fix.

@1t5j0y 1t5j0y moved this from Code Review Ready to In Code Review in Avni Product Apr 2, 2024
@1t5j0y 1t5j0y moved this from In Code Review to QA Ready in Avni Product Apr 2, 2024
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Apr 12, 2024
@AchalaBelokar
Copy link

  • checked with number and also checked whether it is reflected on db

@AchalaBelokar AchalaBelokar moved this from In QA to Done in Avni Product Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants