Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on General Encounter FEG Edit button crashes the app #1400

Closed
2 tasks
Tracked by #1607
himeshr opened this issue May 13, 2024 · 4 comments
Closed
2 tasks
Tracked by #1607

Clicking on General Encounter FEG Edit button crashes the app #1400

himeshr opened this issue May 13, 2024 · 4 comments
Assignees

Comments

@himeshr
Copy link
Contributor

himeshr commented May 13, 2024

Describe the bug
Clicking on General Encounter FEG Edit button crashes the app

To Reproduce
Steps to reproduce the behavior:

  1. Navigate to any Individual which has a General Encounter
  2. Click on any of the Completed General Encounter's Collapsed pane to view its Observations
  3. Click on the "Edit" button specific to a FEG of the encounter
  4. App crashes with error "Cannot read property 'editFormRule' of undefined"

Expected behavior
We should be able to edit General Encounter from a specific FEG position

Screenshots

Screen.Recording.2024-05-13.at.2.40.13.PM.mov

Smartphone:

  • Device: Genymotion Emulator
  • OS: Android 11
  • Version: 8.0 Prod DEV APK

Additional context
This seems to have occurred as regression due to EditFormRule changes done recently.

Developer Checklist
Developer fixing the bug should fill this checklist.

  • Does the fix require extensive regression testing? No
  • Are you mentioning the required scenarios that could be affected? Yes
  • Generic testing for following scenarios
    • Create an Encounter, Individual, Enrolment or ProgramEncounter
    • Edit an Encounter, Individual, Enrolment or ProgramEncounter using edit button
    • Edit an Encounter, Individual, Enrolment or ProgramEncounter from a specific FEG position
@himeshr himeshr self-assigned this May 13, 2024
@github-project-automation github-project-automation bot moved this to New Issues in Avni Product May 13, 2024
@himeshr himeshr moved this from New Issues to Code Review Ready in Avni Product May 13, 2024
@himeshr himeshr moved this from Code Review Ready to QA Ready in Avni Product May 13, 2024
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product May 15, 2024
@AchalaBelokar
Copy link

AchalaBelokar commented May 15, 2024

  • Login with AchalaB@rwbnitiuat search on work order and try to edit the general encounter getting the error earlier it is working
  • Then I login with beulah@rwbngos2023 serch with work order and try to edit it is working fine
  • tested wit maha@power with creating and editing encounter

@himeshr
Copy link
Contributor Author

himeshr commented May 15, 2024

@AchalaBelokar The issue reported here
"Login with AchalaB@rwbnitiuat search on work order and try to edit the general encounter getting the error earlier it is working" is a different issue, but a regression nonetheless.
Will work on fixing it, please continue regression testing across Individual, Program, ProgEnc and Enc Create/Edit/Observation_View/FEG Edit

TrimmedErrorVideo.mp4

@himeshr
Copy link
Contributor Author

himeshr commented May 15, 2024

@AchalaBelokar
The issue reported in previous comment is caused due to Data issue, for that Individual's encounter.. and is not a regression caused due to editFormRule.
A required Field "Farmer" of type SubjectSelect has a value that doesnot belong to this catchment, resulting in error displaying the details.

himeshr added a commit to avniproject/avni-models that referenced this issue May 15, 2024
himeshr added a commit that referenced this issue May 15, 2024
@himeshr
Copy link
Contributor Author

himeshr commented May 15, 2024

We'll show an abnormal color UUID, when SubjectFormElement has Subject which doesnot exist on device.
Screenshot 2024-05-15 at 1 15 00 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants