Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Being able to apply subject type filter on 'Recent' type cards when part of custom dashboard #1436

Closed
Tracked by #912 ...
mahalakshme opened this issue Jun 21, 2024 · 7 comments
Assignees

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Jun 21, 2024

AC:

  • Similar to Being able to apply subject type filter on Due and overdue visits cards when part of custom dashboard #1381
  • Should work for standard report cards 'Recent registrations', 'Recent enrolments', 'Recent visits'
  • For both configurations, applied subject type based(subject type, program, encounter type, program encounter type)
    filters need to work on the above cards. Additionally in configuration 1, if recent duration filter applied that needs to work with or without configuration 2.
  • The filters currently have slightly broken from the expected functionality. When program p and program encounter e filters applied,
    1. recent registrations card need to show individuals enrolled in p and having encounter e(completed or scheduled) and registered within the selected recent duration - found program filter not working sometimes - unable to reproduce now
    2. recent enrolment card need to show individuals enrolled in p and when their enrolments have encounter e(completed or scheduled) and enrolled in p within the selected recent duration
    3. recent visit card need to show individuals enrolled in p and completed e within the selected recent duration
  • The above is just an example. Eg: Multiple program selections, general encounter type filter and other combinations as well need to work
  • For configuration 1, the selected colour from the colour picker need to be applied in the mobile app.
  • The expectation is both configurations will not be used at the same time. But duration range filter in configuration 1 and custom date filters can be applied simultaneously. Eg: Want to see recent registrations in 6 months but with enrolment date range in last 2 days. This is the existing functionality(since date range filters work with recent 24 hours) and we are just retaining it.

Reason for keeping this as separate card inspite of what discussed:

  • Because of existing above issues
  • To ease testing for developers and QA
  • as per INVEST principle
@mahalakshme mahalakshme converted this from a draft issue Jun 21, 2024
@mahalakshme mahalakshme changed the title Being able to apply subject type filter on 'Last 24 hours' type cards Being able to apply subject type filter on 'Last 24 hours' type cards when part of custom dashboard Jun 21, 2024
@mahalakshme mahalakshme moved this from In Analysis to In Analysis Review in Avni Product Jun 21, 2024
@mahalakshme mahalakshme changed the title Being able to apply subject type filter on 'Last 24 hours' type cards when part of custom dashboard Being able to apply subject type filter on 'Recent' type cards when part of custom dashboard Jun 25, 2024
@mahalakshme mahalakshme moved this from In Analysis Review to Analysis Complete in Avni Product Jun 25, 2024
@mahalakshme mahalakshme moved this from Analysis Complete to Ready in Avni Product Jun 26, 2024
@mahalakshme mahalakshme moved this from Ready to Analysis Complete in Avni Product Jun 26, 2024
@mahalakshme mahalakshme moved this from Analysis Complete to Ready in Avni Product Jun 26, 2024
@petmongrels petmongrels moved this from Ready to In Progress in Avni Product Jul 2, 2024
@petmongrels petmongrels self-assigned this Jul 2, 2024
@petmongrels
Copy link
Contributor

Please see - #1437 for commits

@petmongrels petmongrels moved this from In Progress to Code Review Ready in Avni Product Jul 3, 2024
@1t5j0y 1t5j0y moved this from In Code Review to QA Ready in Avni Product Aug 12, 2024
@AchalaBelokar
Copy link

  • due visit is not showing in while creating standard report card.
    Login with jsscp and then try to create a card with due visits
    Image

@AchalaBelokar AchalaBelokar moved this from In QA to QA Failed in Avni Product Sep 16, 2024
@mahalakshme
Copy link
Contributor Author

@AchalaBelokar scheduledVisits is the due Visits - if this is confusing we can deal with it later(create a separate card) - not within the scope for 10.0

@mahalakshme mahalakshme moved this from QA Failed to QA Ready in Avni Product Sep 16, 2024
@AchalaBelokar
Copy link

AchalaBelokar commented Sep 17, 2024

  • I created a standard dashboard with due and overdue visit and apply filter o that that both filter and card is not working for phulwari.

@AchalaBelokar
Copy link

  • Recent Registration is working fine.
  • Recent Enrolment is not working
    Login with maha@jsscp then create individual Tina Min which is enrol in child I created a recent enrolment card but it is not refelecte thereImage
    Image

@AchalaBelokar AchalaBelokar moved this from In QA to QA Failed in Avni Product Sep 17, 2024
@petmongrels
Copy link
Contributor

Please test once after setting the right date and time in your device.

@petmongrels petmongrels moved this from In Progress to QA Ready in Avni Product Sep 17, 2024
@AchalaBelokar
Copy link

AchalaBelokar commented Sep 18, 2024

  • I created a user with name ACH TestAch which is not reflecting any card on custom dashboard I sync 2,3 time ..on my dashboard card it is reflecting. Login with maha@jsscp card is RecentIndiviual
  • I tested on my personal mobile

@AchalaBelokar AchalaBelokar moved this from QA Ready to QA Failed in Avni Product Sep 18, 2024
@petmongrels petmongrels moved this from QA Failed to QA Ready in Avni Product Sep 18, 2024
@AchalaBelokar AchalaBelokar self-assigned this Sep 18, 2024
@AchalaBelokar AchalaBelokar moved this from In QA to Done in Avni Product Sep 19, 2024
@AchalaBelokar AchalaBelokar moved this from In QA to Done in Avni Product Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants