Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard issues of previous release - part 1 #1523

Closed
Tracked by #1465
mahalakshme opened this issue Sep 25, 2024 · 6 comments
Closed
Tracked by #1465

Dashboard issues of previous release - part 1 #1523

mahalakshme opened this issue Sep 25, 2024 · 6 comments
Assignees

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Sep 25, 2024

  1. Refresh button to be in green color.
  2. Change the text to 'Last refreshed on {datetime}' so that that UI will look better. Also this was the text in MyDashboard. And datetime need to be of the format, DD-MM-Year HH:MM. Don't include seconds and don't display in year-month-date format. These are not formats that users know. Eg: 'Last refreshed on 07-09-2024 17:23' (24 hour format is fine, since that was what was used already)
    For translations, refer this

Current screenshots:
Image

Image

  1. For subject type, name of the filter is not reflecting. It is working as expected for Gender.
Screenshot 2024-09-25 at 10 35 20 PM

Analysis notes:

Making hideTotalForProgram work in new MyDashboard might not be needed. Because from this and this looks like were done for 2 orgs - JSSCP and CK. But in JSSCP this setting is set to false and in CK, program and encounter type myDashboard filters itselves looks like are removed. Looks like so this setting is not relevant anymore.

@mahalakshme mahalakshme converted this from a draft issue Sep 25, 2024
@mahalakshme mahalakshme changed the title Improvements to 10.0.0 Improvements/Bugs from 10.0.0 Oct 3, 2024
@mahalakshme mahalakshme changed the title Improvements/Bugs from 10.0.0 Dashboard issues of previous release Oct 3, 2024
@mahalakshme mahalakshme moved this from In Analysis to In Analysis Review in Avni Product Oct 4, 2024
@mahalakshme mahalakshme changed the title Dashboard issues of previous release Dashboard issues of previous release - part 1 Oct 4, 2024
@1t5j0y 1t5j0y self-assigned this Oct 7, 2024
@1t5j0y
Copy link
Contributor

1t5j0y commented Oct 7, 2024

AC2

Used existing standard datetime formatting method to12HourDateTimeFormat to aid readability and have conformity with other date formatting on the dashboard screen.

AC3

'Subject type' filter actually displays corresponding programs and encounters in addition to subject types if configured. Fixed to show the filter name above the subject type selection so user configured filter name is visible. Also, retained 'subjectTypes' sub header and added platform translations so it is correctly rendered for other languages.

@1t5j0y 1t5j0y moved this from In Progress to Code Review Ready in Avni Product Oct 7, 2024
@mahalakshme
Copy link
Contributor Author

mahalakshme commented Oct 7, 2024

@1t5j0y I had suggested the DD-MM-YYYY format because we dont have translations for the months - and there would be users who will not know that as well(I have interacted with users who dont know English at all). didnt notice the as on date - as on date as well was before in DD-MM-YYYY format

@himeshr himeshr moved this from In Code Review to Code Review with Comments in Avni Product Oct 7, 2024
@himeshr
Copy link
Contributor

himeshr commented Oct 7, 2024

Pending the DD-MM-Year HH:MM formating, rest of the changes look fine as per code review stanadards.

@1t5j0y 1t5j0y moved this from Code Review with Comments to In Progress in Avni Product Oct 8, 2024
@1t5j0y
Copy link
Contributor

1t5j0y commented Oct 8, 2024

Changed format for last refreshed message and as on date display. This also changes display format wherever DatePicker is used.
image

@1t5j0y 1t5j0y moved this from In Progress to QA Ready in Avni Product Oct 8, 2024
@dinesh2096
Copy link

  • Can we have same format everywhere

References :

Image

@dinesh2096 dinesh2096 moved this from In QA to QA Failed in Avni Product Oct 29, 2024
@dinesh2096
Copy link

QA Reference video :

Click here to watch the video

@dinesh2096 dinesh2096 self-assigned this Oct 30, 2024
@dinesh2096 dinesh2096 moved this from In QA to Done in Avni Product Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

5 participants