Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading of a form takes more time #1544

Closed
mahalakshme opened this issue Nov 8, 2024 · 2 comments
Closed

Loading of a form takes more time #1544

mahalakshme opened this issue Nov 8, 2024 · 2 comments
Assignees

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Nov 8, 2024

https://avni.freshdesk.com/a/tickets/4908

Issue:

env: prod, apk: 10.0.3, user: maha@shelter -> login -> search household 0155 -> Click on Edit of 'Household Level daily reporting' - it takes 30 secs to render the form

in 9.4.0, it only takes less than a second to get rules of type ViewFilter. It takes less than 5 secs to render the form.
Image

But in 10.0.3, it takes more than 10 secs to get rules of type ViewFilter.
Image
Issue video recording: Link

AC:

  • Loading of the Edit page should not take more than 5 secs

Technical analysis:

Why is rules of Type ViewFilter fetched twice (both in 9.1 and 10.0)? Fix it if possible

@mahalakshme mahalakshme converted this from a draft issue Nov 8, 2024
@mahalakshme mahalakshme moved this from In Analysis to Ready in Avni Product Nov 8, 2024
@himeshr himeshr self-assigned this Nov 8, 2024
@himeshr himeshr moved this from Ready to In Progress in Avni Product Nov 8, 2024
himeshr added a commit to avniproject/avni-models that referenced this issue Nov 8, 2024
himeshr added a commit to avniproject/avni-models that referenced this issue Nov 8, 2024
…for formElementGroup.nonVoidedFormElements
himeshr added a commit that referenced this issue Nov 8, 2024
@himeshr
Copy link
Contributor

himeshr commented Nov 8, 2024

On debug, found that the additional logic introduced to filter out formElements whose parent formElement entities are voided, had caused severe degradation of performance.
Using a hashmap restored the performance to previous levels seen in apk of version 9.4.
Added a functional and performance criteria test for the same, the test before fix took ~4.5 seconds, but after fix took less than 100 milliseconds.

himeshr added a commit to avniproject/avni-models that referenced this issue Nov 8, 2024
…i build failures (on local should be less than 100ms)
himeshr added a commit to avniproject/avni-models that referenced this issue Nov 8, 2024
himeshr added a commit that referenced this issue Nov 8, 2024
himeshr added a commit to avniproject/avni-models that referenced this issue Nov 8, 2024
@himeshr himeshr moved this from In Progress to Code Review Ready in Avni Product Nov 8, 2024
@1t5j0y 1t5j0y moved this from In Code Review to QA Ready in Avni Product Nov 11, 2024
@dinesh2096
Copy link

QA Reference :

Click here to watch video

@dinesh2096 dinesh2096 self-assigned this Nov 11, 2024
@dinesh2096 dinesh2096 moved this from In QA to Done in Avni Product Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants