Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metabase setup status not shown correctly #854

Open
mahalakshme opened this issue Feb 7, 2025 · 1 comment
Open

Metabase setup status not shown correctly #854

mahalakshme opened this issue Feb 7, 2025 · 1 comment

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Feb 7, 2025

Issue:

org: shelter, env: staging

  • Currently even if creation of reports fails, on refresh of page when it is loading, it shows as 'Setup done'
Image

Tech detail:

  • It is because in organisation_config table we are keeping track a variable called, metabaseSetupEnabled whose set value seems to be in contradiction with the success status of Metabase Canned Reports setup which is still under progress.
  • Also we are setting the metabase via foreground thread and refresh of the page will not complete the setup, say in case metabase during refresh is only in its second step and collection creation which is 4th step may not get completed.
    ie., /setup-toggle endpoint implementation needs to be made more robust so the status conveyed and shown in the UI is consistent.

AC:

  • Status should not show as Done, when it is not Done.
  • Refresh of the page or moving to a different page as well should show the status of Metabase setup correctly(ie., either loading or Done or the UI for not triggered)
  • Should work in a consistent manner for orgs with large data as well.
@mahalakshme mahalakshme converted this from a draft issue Feb 7, 2025
@mahalakshme mahalakshme changed the title Metabase setup via batch job Metabase setup status getting shown incorrectly Feb 10, 2025
@mahalakshme mahalakshme moved this from In Analysis to Ready in Avni Product Feb 10, 2025
@mahalakshme mahalakshme moved this from Ready to In Analysis in Avni Product Feb 10, 2025
@mahalakshme mahalakshme changed the title Metabase setup status getting shown incorrectly Metabase setup status shown incorrectly Feb 10, 2025
@mahalakshme mahalakshme moved this from In Analysis to Ready in Avni Product Feb 10, 2025
@mahalakshme mahalakshme changed the title Metabase setup status shown incorrectly Metabase setup status not shown correctly Feb 10, 2025
@himeshr himeshr self-assigned this Feb 11, 2025
@himeshr himeshr moved this from Ready to In Progress in Avni Product Feb 11, 2025
@himeshr himeshr moved this from In Progress to Ready in Avni Product Feb 11, 2025
@himeshr himeshr removed their assignment Feb 11, 2025
@himeshr
Copy link
Contributor

himeshr commented Feb 11, 2025

Moved back as other Metabase cards are in progress and we want to serialize the code changes to avoid conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready
Development

No branches or pull requests

2 participants