Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image for Twitter Card auto-tweets is too large #265

Open
jcn opened this issue May 3, 2017 · 0 comments
Open

Image for Twitter Card auto-tweets is too large #265

jcn opened this issue May 3, 2017 · 0 comments
Labels

Comments

@jcn
Copy link
Member

jcn commented May 3, 2017

This is not strictly a bug in our code, but since we use our Atom feed to serve twitter images (via zapier), sometimes this doesn't work because we are just feeding the raw image url, which can sometimes be huge. We should detect when this image is too large for the feed (something reasonable, though twitter cards can be a max of 4096x4096) and downsize if needed.

We should not upsize smaller photos, however.

@jcn jcn added the bug label May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant