Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types in one place? #47

Open
jhanstra opened this issue Jun 4, 2017 · 2 comments
Open

types in one place? #47

jhanstra opened this issue Jun 4, 2017 · 2 comments
Assignees

Comments

@jhanstra
Copy link
Collaborator

jhanstra commented Jun 4, 2017

I haven't used Flow before so this might be a bad idea - but would it make sense to put all of our Flow types in one file or folder? Is that even possible?

@awitherow
Copy link
Owner

It is quite possible!

On run, https://github.com/awitherow/coinbot/blob/master/index.js gets called, which includes the package 'flow-remove-types/register'. This will strip all flow related stuff.

Therefore we could make a file, maybe src/types.js and use the es6 import/export syntax to import and export types in other files, just as you would reference a function.

You wanna take a crack at it?

@awitherow
Copy link
Owner

Actually, since you're actively working on #45 I'll get this done.

@awitherow awitherow self-assigned this Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants