Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi language support #35

Open
BlartVersenwald opened this issue Nov 17, 2024 · 3 comments
Open

Multi language support #35

BlartVersenwald opened this issue Nov 17, 2024 · 3 comments

Comments

@BlartVersenwald
Copy link

toyName must be localized string otherwise macro would work only in english language.

I believe it should be as simple as this

		-- Randomly pick one.
		local itemID = RandomKey(UsableHearthToyIndex)
		local _, toyName = C_ToyBox.GetToyInfo(itemID)
@awls99
Copy link
Owner

awls99 commented Nov 18, 2024 via email

@BlartVersenwald
Copy link
Author

Simple change above works for me perfectly (english/cyrillic client)

@JamienAU
Copy link

JamienAU commented Jan 5, 2025

Yeah I know I broke localisation, but it actually came in the back of the fact the GetToyInfo method not working correctly more than half the time, leading to people's hs not loading, not changing or only a rotating through a couple of them.

Likely the toy info hasn't loaded when you're calling that, so it's returning null.
Have a look into ContinueOnItemLoad().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants