Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module 'aft_common.feature_options' has no attribute 'get_target_account_and_customization_id_from_event' #507

Open
jo-koe opened this issue Nov 6, 2024 · 1 comment
Labels
bug Something isn't working pending investigation Issue needs further investigation

Comments

@jo-koe
Copy link

jo-koe commented Nov 6, 2024

Terraform Version & Prov:

AFT Version:
1.13.2

Terraform Version & Provider Versions
N/A

terraform version
N/A

terraform providers
N/A

Bug Description
We see below error if an existing Account Request JSON is updated:

{"errorMessage": "module 'aft_common.feature_options' has no attribute 'get_target_account_and_customization_id_from_event'", "errorType": "AttributeError", "requestId": "be0a3bd9-1c8c-49e4-9578-6e770320387d", "stackTrace": ["  File \"/var/task/aft_enroll_support.py\", line 27, in lambda_handler\n    feature_options.get_target_account_and_customization_id_from_event(event=event)\n"]}

To Reproduce
Update an existing account request JSON file and merge/push into main which triggers the Step Function.

Expected behavior
No error message is thrown.

Related Logs
See below.

Additional context

It seems this function was introduced in the last AFT version:
cd751f4#diff-181cd51b57200d31062c6f0aa61f3410cfee32f29248c3e1211401c344158b05R27

@jo-koe jo-koe added bug Something isn't working pending investigation Issue needs further investigation labels Nov 6, 2024
@floryut
Copy link

floryut commented Nov 15, 2024

We got the same issue here.

Had to comment the function to make a quick&dirty workaround.

    #request_id, target_account_id = (
    #    feature_options.get_target_account_and_customization_id_from_event(event=event)
    #)

Looks like the aft-common-1-13-2 package does not include those 2 new function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pending investigation Issue needs further investigation
Projects
None yet
Development

No branches or pull requests

2 participants