Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add informational thread annotations to customer-facing methods #267

Open
tmilovan123 opened this issue Apr 9, 2021 · 0 comments
Open
Labels
documentation Improvements or additions to documentation

Comments

@tmilovan123
Copy link

Based on the discussions @hokyungh and I had about this issue.
Sometimes some of the exposed methods might do a lot of work on the UI thread, and moving them off UI thread can resolve certain issues.
However, as a consumer of the SDK, we cannot be sure a certain method is safe to be called off UI thread or not. It can be determined by reading the code sometimes, but this approach requires some time and effort.
Suggestion: annotate publicly facing methods with MainThread, AnyThread and WorkerThread accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Tell Us What You Need
Development

No branches or pull requests

2 participants