Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background filters flip the video upside-down before joining a meeting #517

Open
Jim-Bar opened this issue Nov 17, 2022 · 15 comments
Open
Labels
bug Something isn't working Triaged

Comments

@Jim-Bar
Copy link

Jim-Bar commented Nov 17, 2022

Hi. Recently a fix was made so that it is possible to use background blur / replacement image before joining a meeting session on Android: #504. But now when using those filters before joining a meeting, the video is upside-down.

  1. Implement a blur filter
  2. Apply it to the video preview, not being in a meeting
  3. The blur is applied, but the video is upside down

The same occurs with the background replacement image.

This is actually a follow up on the comments I already posted in the original issue.

Tested on a Samsung Galaxy S20 FE, Android 12 and:

  • Amazon Chime SDK 0.17.7
  • Amazon Chime SDK Machine learning 0.1.0
  • Amazon Chime SDK Media 0.17.8

See this video:

Bug-Chime-Blur-Background-before-LIVE.mp4
@dingyishen-amazon
Copy link
Contributor

Thanks for reporting the issue, we will investigate it.

@hokyungh
Copy link
Contributor

hokyungh commented Dec 1, 2022

Thank you for reporting I am able to reproduce the issue. We'll do further investigation and get back to you.

@hokyungh
Copy link
Contributor

hokyungh commented Dec 1, 2022

This is due to flipping logic in here. I think internally it comes as flipped which works in this case, but in usual case it might not be working. We'll think of better way to fix this.

@hokyungh hokyungh added the bug Something isn't working label Dec 1, 2022
@Jim-Bar
Copy link
Author

Jim-Bar commented Dec 2, 2022

All right, thank you for your investigation. We are looking forward to this bug fix.

@Jim-Bar
Copy link
Author

Jim-Bar commented Jan 4, 2023

Hi, do you have news on this?

@hokyungh hokyungh self-assigned this Jan 5, 2023
@hokyungh
Copy link
Contributor

hokyungh commented Jan 5, 2023

HI sorry I am still working on this issue. I'll let you know when I have solution for this issue.

@hokyungh hokyungh removed their assignment Jan 5, 2023
@Jim-Bar
Copy link
Author

Jim-Bar commented Mar 8, 2023

Hi, this is still an issue for us. Has it been fixed in a new version?

@Jim-Bar
Copy link
Author

Jim-Bar commented Apr 27, 2023

Hello, sorry to ping repeatedly, but this is still an issue for us. Do you have news on this?

@hokyungh
Copy link
Contributor

Hi sorry for late reply. Unfortunately, I was still caught up with other tasks and didn't have time to work on it. We'll let you know once we work on it, but for short-term mitigation, would it be possible to implement CustomBackgroundProcessor before joining that resembles BackgroundFilterVideoFrameProcessor.kt?

@kackogut
Copy link

@hokyungh any news on this one? It's still occurring on the latests (0.19.1) release

@Sotatek-HungHa2
Copy link

I tried creating a CustomBackgroundReplacementVideoFrameProcessor, CustomBackgroundFilterVideoFrameProcessor is the same as BackgroundReplacementVideoFrameProcessor, BackgroundFilterVideoFrameProcessor file. In the CustomBackgroundReplacementVideoFrameProcessor file, replace BackgroundFilterVideoFrameProcessor with CustomBackgroundFilterVideoFrameProcessor. In the CustomBackgroundFilterVideoFrameProcessor file, add VideoRotation.Rotation180 to the VideoFrame. And it worked
image

@PalankiBharat
Copy link

I tried creating a CustomBackgroundReplacementVideoFrameProcessor, CustomBackgroundFilterVideoFrameProcessor is the same as BackgroundReplacementVideoFrameProcessor, BackgroundFilterVideoFrameProcessor file. In the CustomBackgroundReplacementVideoFrameProcessor file, replace BackgroundFilterVideoFrameProcessor with CustomBackgroundFilterVideoFrameProcessor. In the CustomBackgroundFilterVideoFrameProcessor file, add VideoRotation.Rotation180 to the VideoFrame. And it worked image

I am getting an error while creating CustomBackgroundFilter
VideoFrameProcessor there i am geting error for some functions and variables of Segment processor class how did you manage that ?

Screenshot 2024-08-27 at 12 53 42 PM

Screenshot 2024-08-27 at 12 54 19 PM

@Sotatek-HungHa2
Copy link

I tried creating a CustomBackgroundReplacementVideoFrameProcessor, CustomBackgroundFilterVideoFrameProcessor is the same as BackgroundReplacementVideoFrameProcessor, BackgroundFilterVideoFrameProcessor file. In the CustomBackgroundReplacementVideoFrameProcessor file, replace BackgroundFilterVideoFrameProcessor with CustomBackgroundFilterVideoFrameProcessor. In the CustomBackgroundFilterVideoFrameProcessor file, add VideoRotation.Rotation180 to the VideoFrame. And it worked image

I am getting an error while creating CustomBackgroundFilter VideoFrameProcessor there i am geting error for some functions and variables of Segment processor class how did you manage that ?

Screenshot 2024-08-27 at 12 53 42 PM

Screenshot 2024-08-27 at 12 54 19 PM

Segment processor class is managed by Chime Sdk. This is the version i used
image

@PalankiBharat
Copy link

PalankiBharat commented Aug 27, 2024

Segment processor class is managed by Chime Sdk. This is the version i used image

I have used the same can you share with me your CustomBackgroundReplacementVideoFrameProcessor and CustomBackgroundFilterVideoFrameProcessor if that is not a problem ?

@Sotatek-HungHa2
Copy link

CustomBackgroundReplacementVideoFrameProcessor
Archive.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Triaged
Projects
None yet
Development

No branches or pull requests

7 participants